Skip to content

Use correct "golden.eval" postfix for workflow and script #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −6
Open

Use correct "golden.eval" postfix for workflow and script #7422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b032a2c
Use correct "golden.eval" postfix for workflow and script
SeungheonOh Nov 15, 2025
b036a14
Fix fetching names
SeungheonOh Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/compare-golden-budgets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: "🏆 Compare Golden Budgets"
on:
pull_request:
paths:
- '**.eval.golden'
- '**.golden.eval'

jobs:
run-script:
Expand Down
10 changes: 5 additions & 5 deletions scripts/eval-percent-diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
# diff‑budget.sh – show percent deltas for *.eval.golden metrics
# diff‑budget.sh – show percent deltas for *.golden.eval metrics
# Usage: diff‑budget.sh [-t] [<base-commit>]
# -t output as Markdown tables instead of colored text

Expand Down Expand Up @@ -31,9 +31,9 @@ if [[ $# -gt 1 ]]; then
usage
elif [[ $# -eq 1 ]]; then
BASE="$1"
GIT_DIFF_CMD=(git diff "$BASE" -- '*.eval.golden')
GIT_DIFF_CMD=(git diff "$BASE" -- '*.golden.eval')
else
GIT_DIFF_CMD=(git diff -- '*.eval.golden')
GIT_DIFF_CMD=(git diff -- '*.golden.eval')
fi

# --- run diff and post‑process ----------------------------------------------
Expand All @@ -51,7 +51,7 @@ if [[ $TFLAG -eq 1 ]]; then
file=""; seen=0;
}
# new file header: reset seen flag, store filename
/^--- a\/.*\.eval\.golden/ {
/^--- a\/.*\.golden\.eval/ {
file = substr($2,3)
seen = 0
next
Expand Down Expand Up @@ -99,7 +99,7 @@ else
file=""; seen=0;
}
# new file header: reset seen flag, store filename
/^--- a\/.*\.eval\.golden/ {
/^--- a\/.*\.golden\.eval/ {
file = substr($2,3)
seen = 0
next
Expand Down