Improve error handling, safety, readability; replace unsafe patterns. #7446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modernize sorting ✅ Pull Request: Improve Error Handling, Safety & Readability Summary This pull request improves the stability, safety, and readability of the PIR tool without changing its core functionality. Changes Made Replaced unsafe pattern matches on Program with safe bindings. Replaced raw error calls with friendly error messages + exitFailure. Improved readability in retention analysis and name table generation. Updated sorting using Down for cleaner intent. Added simple CLI messages for better user feedback. Added comments explaining intentional orphan instances. Removed minor redundancies and improved formatting. Why This Matters These changes: Prevent sudden crashes caused by pattern-match failures Make CLI errors easier to understand Improve maintainability Do not change logic or output format No Functional Behavior Changed This PR is safe, review-friendly, and strictly improves code quality.
Author
|
This PR improves the PIR tool by:
All CI checks are expected to pass; feedback is welcome. |
Onyinyechi46
approved these changes
Nov 22, 2025
| Left e -> error $ show e | ||
| Right t -> writeProgram outp (pirFormatToFormat ofmt) mode | ||
| (Program () PLC.latestVersion(void t)) | ||
| prog <- readProgram (pirFormatToFormat ifmt) inp |
There was a problem hiding this comment.
Honestly this is superb, Dev
This .hs file is easy to comprehend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… modernize sorting
✅ Pull Request: Improve Error Handling, Safety & Readability Summary
This pull request improves the stability, safety, and readability of the PIR tool without changing its core functionality.
Changes Made
Replaced unsafe pattern matches on Program with safe bindings.
Replaced raw error calls with friendly error messages + exitFailure.
Improved readability in retention analysis and name table generation.
Updated sorting using Down for cleaner intent.
Added simple CLI messages for better user feedback.
Added comments explaining intentional orphan instances.
Removed minor redundancies and improved formatting.
Why This Matters
These changes:
Prevent sudden crashes caused by pattern-match failures
Make CLI errors easier to understand
Improve maintainability
Do not change logic or output format
No Functional Behavior Changed
This PR is safe, review-friendly, and strictly improves code quality.
Pre-submit checklist: