Port the build system from python2 to python3#25
Open
mateusz-banaszek wants to merge 2 commits intoInviNets:masterfrom
Open
Port the build system from python2 to python3#25mateusz-banaszek wants to merge 2 commits intoInviNets:masterfrom
mateusz-banaszek wants to merge 2 commits intoInviNets:masterfrom
Conversation
added 2 commits
September 17, 2020 16:47
Change `python` to `python3` in one more file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most (all?) of the tools used within the project use python3. But whip6-pub still requires python2. Let's try to move it forward too.
Tu upgrade, just pull the source and run it. You may need to install into your python3 environment the dependencies:
pip install pyaml termcolor. There should be no need to reinstall or re-link whip6-pub/smake.I did verify on a few apps that
smake cherrygives the same output before and after the change (modulo randomized numbers). I also successfully run those apps on a CherryMote.However, I didn't test whether all
smake xx yycommands work – I haven't been aware of them till today, and I have never used them at all.The files were ported by a combination of my manual work and a help of the
2to3tool. Except fornesc/whip6/platforms/tools/programmer/ccbsl/cc2538-bsl.pyandnesc/whip6/platforms/tools/programmer/ccbsl/intelhex/*: they were upgraded to their newest upstream states (pulled from here and here respectively).