Skip to content

Add stellar-cli sandbox lifecycle test#567

Open
Killerjunior wants to merge 3 commits into
Iris-IV:mainfrom
Killerjunior:codex/501-stellar-cli-sandbox-integration
Open

Add stellar-cli sandbox lifecycle test#567
Killerjunior wants to merge 3 commits into
Iris-IV:mainfrom
Killerjunior:codex/501-stellar-cli-sandbox-integration

Conversation

@Killerjunior

Copy link
Copy Markdown

📌 Description

Adds a CI integration job that runs the deployed contract against a real stellar-cli local sandbox. The new script starts a local Stellar container, deploys the contract WASM and native asset contract, then exercises the happy-path lifecycle: initialize, create campaign, verify campaign, contribute, withdraw funds, and assert final on-chain state.

🔗 Related Issues

Closes #501

🧪 Changes Made

  • Bug fix
  • New feature
  • Refactor
  • Documentation update

✅ Checklist

  • Code compiles successfully
  • Tests added/updated and passing
  • Linting passes (no warnings/errors)
  • Documentation updated (if required)
  • No breaking changes (or clearly documented)

⚠️ Breaking Changes

None.

📸 Screenshots (if applicable)

Not applicable.

🧩 Additional Notes

The sandbox test is implemented in scripts/stellar_cli_happy_path.sh and wired into .github/workflows/ci.yml as the stellar-cli-sandbox job. I could not execute the sandbox locally because this Windows environment does not have Bash or stellar installed; CI will run it on Ubuntu.

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@davidmaronio

Copy link
Copy Markdown
Contributor

the sandbox lifecycle script itself is reasonable (set -euo pipefail, a network health-wait loop, an exit trap to stop the container, isolated XDG_CONFIG_HOME). the fmt/clippy/test reds are from a stale base that doesn't compile (missing token/uses_milestones on CreateCampaignParams, duplicate set_emergency_pause_signers), none of that is in your diff. rebase onto current main and it should go green. minor: the new job runs cargo install --locked stellar-cli unpinned, pinning a version would make it reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add integration test against stellar-cli local sandbox for full happy-path lifecycle

2 participants