-
Notifications
You must be signed in to change notification settings - Fork 0
Make bumpie-meds pregnancy safety modules optional dependencies #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
80f0077
Initial plan
Copilot be48d16
Initial plan for fixing missing bumpie-meds module
Copilot 513d4f6
Fix missing bumpie-meds module with optional dependency handling
Copilot f73fecd
Address code review: only catch MODULE_NOT_FOUND errors
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the catch treats any
MODULE_NOT_FOUNDas “optional dependency missing,” a broken install ofbumpie-meds(e.g., a missing transitive dependency or a renamed internal file) will be silently swallowed and pregnancy safety will be disabled without surfacing the real error. This makes production misconfigurations look like an expected optional state and can lead to missing safety checks even when the package is present. Consider only suppressing errors when the missing module is thebumpie-medspackage itself (e.g., checkerror.message/require.resolve), and rethrow otherMODULE_NOT_FOUNDcases.Useful? React with 👍 / 👎.