Skip to content

Fix ESLint v10 peer dependency conflicts - #103

Merged
Isaloum merged 2 commits into
dependabot/npm_and_yarn/eslint-10.0.0from
copilot/fix-eslint-peer-dependency-issues
Feb 10, 2026
Merged

Fix ESLint v10 peer dependency conflicts#103
Isaloum merged 2 commits into
dependabot/npm_and_yarn/eslint-10.0.0from
copilot/fix-eslint-peer-dependency-issues

Conversation

Copilot AI commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

ESLint v10 upgrade in PR #99 caused CI failures with exit code 2 due to eslint-plugin-prettier@5.1.3 incompatibility.

Changes

  • package.json: Bump eslint-plugin-prettier from ^5.1.3 to ^5.5.5
  • package-lock.json: Regenerate to resolve peer dependency conflicts

The v5.5.5 release properly supports ESLint v10's peer dependency requirements, resolving installation failures in CI environments.

Original prompt

Problem

The CI job 63058613182 is failing in PR #99 with ESLint exiting with code 2. The issue is caused by ESLint v10 upgrade which has breaking changes and peer dependency conflicts.

Looking at the error logs:

at Object.format (/home/runner/work/TaxSyncForDrivers/TaxSyncForDrivers/node_modules/eslint/lib/eslint/eslint.js:1271:12)
at printResults (/home/runner/work/TaxSyncForDrivers/TaxSyncForDrivers/node_modules/eslint/lib/cli.js:118:33)
##[error]Process completed with exit code 2.

The package-lock.json shows ESLint v10.0.0, eslint-config-prettier, eslint-plugin-prettier, and several other ESLint-related packages marked with "peer": true, indicating they're not being installed correctly.

Root Cause

ESLint v10 has stricter requirements and the current plugin versions (eslint-config-prettier@10.1.8 and eslint-plugin-prettier@5.1.3) are not fully compatible with ESLint v10.

Solution Required

Fix the peer dependency issue by ensuring ESLint and its plugins are properly installed and compatible:

  1. Update package-lock.json to remove the "peer": true markers from eslint and related packages so they install as direct dependencies
  2. Ensure the globals package (already added in package.json) is properly integrated
  3. Verify the eslint.config.js is correct for ESLint v10

The eslint.config.js at commit 5d4e3b1 already has:

  • Import of globals package
  • Proper flat config format for ESLint v10
  • Correct global declarations using ...globals.browser and ...globals.node

What needs to be fixed:

  • Regenerate package-lock.json with correct dependency resolution (removing "peer": true from eslint, eslint-config-prettier, eslint-plugin-prettier, prettier, playwright-core, and acorn)
  • Ensure all packages install as proper dependencies, not peer dependencies

This should allow ESLint v10 to run successfully in CI.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Removed node_modules and package-lock.json
- Updated eslint-plugin-prettier from ^5.1.3 to ^5.5.5 for better ESLint v10 compatibility
- Ran npm install to regenerate package-lock.json with proper dependency resolution
- Verified ESLint runs successfully with 0 errors (40 warnings expected)

Co-authored-by: Isaloum <155708736+Isaloum@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix ESLint peer dependency issues after v10 upgrade Fix ESLint v10 peer dependency conflicts Feb 10, 2026
Copilot AI requested a review from Isaloum February 10, 2026 04:43
@Isaloum
Isaloum marked this pull request as ready for review February 10, 2026 04:44
@Isaloum
Isaloum merged commit e86c492 into dependabot/npm_and_yarn/eslint-10.0.0 Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants