fix(cli): recognise Unity 2020.2+ "Enter Safe Mode?" launch-errors dialog (#737)

[IvanMurzak]

Summary

Reopens issue #737 — the auto-dismiss helper added in #738 never matched the dialog on any modern Unity (2022 LTS, 6000.x), so the resolver-fix flow the issue was opened to enable still couldn't run. Two root causes:

• Wrong title. Unity 2020.2+ renamed the launch-errors dialog to "Enter Safe Mode?". The matcher's title-fragment list only knew the legacy spellings ("Compiler Errors", "Hold On", "Compile Errors", "Scripts have compiler errors"), so EnumWindows / osascript / xdotool never found a candidate window and the click path was unreachable. Added "Safe Mode" to LAUNCH_ERROR_DIALOG_TITLE_FRAGMENTS.
• Grace window too short. The no-dialog grace defaulted to 3000 ms, but on Unity 2022.3.62f3 the dialog only appears at ~6 s post-spawn (after the editor process boots, connects to Package Manager, and starts compiling). The polling loop bailed out before the dialog ever rendered. Bumped the default to 15000 ms — large enough to cover Unity's startup phase on a slow disk while still cutting the no-dialog case short of the full --launch-dismiss-timeout-ms.

While here, single-sourced the PowerShell TitleFragments C# array off LAUNCH_ERROR_DIALOG_TITLE_FRAGMENTS via template-literal interpolation (matching the existing ${DISMISS_BUTTON_LABEL} pattern a line below), so the next Unity dialog rename is a one-line change instead of two-places-to-keep-in-sync — which is exactly the bug class this PR is fixing.

Empirical evidence (Unity 2022.3.62f3 / Windows)

Instrumented EnumWindows probe of the broken Unity-MCP-Plugin project (deliberate compile-error script in Assets/):

t (s)	Visible Unity-owned windows
0–2	none
3	UnitySplashWindow "Open Project" + Package Manager static labels
5	UnitySplashWindow "Compiling Scripts"
6+	#32770 dialog title="Enter Safe Mode?", buttons=&Enter Safe Mode / &Ignore / &Quit

The existing button matcher ("Ignore" / "&Ignore") already handles &Ignore, so once the title matches the dismiss path works as designed.

Trade-off

Bumping the grace from 3 s to 15 s adds up to ~12 s extra wait in the no-dialog case (well-formed project, no compile errors). This is accepted because the alternative — the current behavior — is the auto-dismiss being 100% broken on every modern Unity release.

Test plan

• Vitest CLI suite — 347 pass / 1 pre-existing skip (was 347 / 1 baseline).
• Two regression locks added in launch-error-dismiss.test.ts: "safe mode" is in the fragments list, and the empirically-observed "Enter Safe Mode?" title is matched by at least one fragment via the case-insensitive substring rule the producers use.
• End-to-end on Windows / Unity 2022.3.62f3 against Unity-MCP-Plugin with the deliberate compile-error script — unity-mcp-cli open now logs [open] dismissed Unity launch-errors dialog (button=Ignore, platform=win32) and the dialog stays gone (verified with a follow-up EnumWindows probe 8 s after dismissal).
• Existing 'includes every documented title fragment' PS-script test continues to pass after the interpolation refactor — confirms the rendered PowerShell script byte-matches the prior hardcoded line for the existing fragments and now also includes "Safe Mode".
• macOS — not retested. AppleScript path iterates Unity's windows looking for a button labelled Ignore; that button still exists in the new dialog, so the path should be unaffected, but a fresh manual test on Unity 2022.3+ on macOS would confirm.
• Linux/X11 — not retested. The Linux path searches by the same title-fragment list and now includes "Safe Mode"; same caveat as macOS.

Closes #737.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates the CLI’s Unity launch-errors auto-dismiss logic so it correctly detects the modern Unity 2020.2+ “Enter Safe Mode?” dialog and waits long enough for that dialog to appear during editor startup, improving the reliability of the self-healing/resolver flow when projects launch with compile errors.

Changes:

• Add "Safe Mode" to LAUNCH_ERROR_DIALOG_TITLE_FRAGMENTS and add regression tests to ensure “Enter Safe Mode?” is matched.
• Increase the default “no dialog observed” grace window from 3s to 15s in the polling loop and update related documentation.
• Single-source the Windows PowerShell script’s C# TitleFragments array from LAUNCH_ERROR_DIALOG_TITLE_FRAGMENTS to avoid drift.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
cli/tests/launch-error-dismiss.test.ts	Adds regression tests ensuring the new Safe Mode dialog title is matched.
cli/src/utils/launch-error-dismiss.ts	Adds the Safe Mode title fragment and templates PowerShell TitleFragments from the shared constant.
cli/src/lib/types.ts	Updates OpenProjectOptions documentation to reflect the longer startup/grace timing rationale.
cli/src/lib/open.ts	Bumps the default no-dialog grace window to 15000ms and updates comments to match.
cli/README.md	Updates open command docs to describe the modern dialog title and longer startup phase before it appears.

Comments suppressed due to low confidence (1)

cli/src/utils/launch-error-dismiss.ts:50

• Adding the "Safe Mode" title fragment means the Linux/X11 xdotool path can now match the modern "Enter Safe Mode?" dialog. However, the Linux implementation dismisses by activating the window and sending Return to the focused button (see tryDismissLinuxX11), which is not guaranteed to be the "Ignore" button on this dialog (it also has "Enter Safe Mode" / "Quit"). This can cause the auto-dismiss to take the wrong action on Linux. Consider changing the Linux strategy to explicitly target the Ignore action (e.g., send the Ignore accelerator if Unity exposes &Ignore, or otherwise avoid relying on the default focus).

export const LAUNCH_ERROR_DIALOG_TITLE_FRAGMENTS: readonly string[] = [
  'Safe Mode', // Unity 2020.2+ ("Enter Safe Mode?") — the launch-errors dialog on every modern Unity (2022 LTS, 6000.x)
  'Compiler Errors', // Unity 2020+ ("Hold On" + "Compiler Errors on Launch")
  'Hold On', // Generic Unity progress dialog wrapping the launch-errors variant
  'Compile Errors', // Older Unity dialog spelling
  'Scripts have compiler errors', // Unity 2022+ on Linux (window manager surfacing)