Open
Conversation
Zoom in/out via +/- UI buttons, scroll wheel, and keyboard shortcuts. Smooth lerp interpolation, clamped to configurable min/max bounds, zoom level persisted to localStorage across sessions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zoom in/out via +/- UI buttons, scroll wheel, and keyboard shortcuts. Smooth lerp interpolation with epsilon gating to avoid per-frame projection matrix rebuilds at rest. Zoom state in dedicated cameraStore (separated from playerStore), persisted to localStorage. Trackpad pinch-to-zoom passthrough (ctrlKey check), contentEditable-aware keyboard handler, ZoomControls moved to ui/camera/ for consistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Surface staged review process, bug fix trails, and test coverage for visitors who won't click into PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Protect implementation code while keeping it publicly viewable. Anyone who distributes or runs this as a service must open-source their derivative work under AGPL v3 or negotiate a commercial license. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cameraStore(separated fromplayerStoreto avoid unrelated re-renders), persisted to localStorageReview Findings
Self-review found 7 issues (3M, 4L) — all resolved in this PR:
updateProjectionMatrix()gated on epsilon check — no longer called 60x/sec at restplayerStoreinto dedicatedcameraStoree.ctrlKeyto pass through trackpad pinch-to-zoomisContentEditablein addition to form elementsZoomControlsmoved fromui/toui/camera/to match existing subdirectory conventionCAMERA_ZOOMJSDoc updated from "Camera orthographic zoom level" to "Default camera zoom level"Test plan
pnpm test— 411 tests passing (8 new cameraStore tests)tsc --noEmit— no type errorsGenerated by Claude Code · Claude Opus 4.6