Merged
Conversation
Implements the full PlanTree component suite: SVG dependency overlay with bezier curves, CSS grid expand/collapse animations, WAI-ARIA treeview keyboard navigation, search/filter with text highlighting, and runtime HSL theme configurator with localStorage persistence. 19 new files, 52 new tests (211 frontend total). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix Rules of Hooks: move all hooks above conditional return in PlanTreeNode (useRef, useRegisterNode, useDependencyContext, useCallback all called before visibility check) - Fix CSS selector injection: use CSS.escape() in querySelector calls in useTreeKeyboard and index.tsx - Remove duplicate Escape handler from NodeDetail that conflicted with useTreeKeyboard's Escape handling (double-fire) - Fix stale closure in ThemeConfigurator togglePopover by using callback form of setOpen - Pre-compute reverse dependency map (downstreamMap) in DependencyContext to replace O(n) forEach+includes scan per node - Re-sync expand state when tree identity changes via useEffect on defaultMap, preserving user overrides for existing nodes - Remove unnecessary recalculation on hover in DependencyOverlay (paths don't move, only styling changes) - Reformat compressed single-line CSS rules in theme configurator and search sections for consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Review Defect Fixes (commit 4472667)8 defects found during self-review, all fixed: High Severity
Medium Severity
Low Severity
Nit
|
The global Escape listener was removed in the prior commit to fix double-firing with useTreeKeyboard. But this left the detail panel with no Escape support when it has focus (e.g., user clicks inside to select text). Added a scoped onKeyDown on the panel div instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<mark>text highlighting, and runtime HSL theme configurator with localStorage persistenceuseExpandState), keyboard hook (useTreeKeyboard), search hook (useTreeSearch), and reactive theme hook (usePlanTreeThemewith MutationObserver for dark/light detection)Test plan
cd frontend && npx tsc --noEmit— cleancd frontend && npm test— 211 tests passing (26 test suites)Generated by Claude Code · Claude Opus 4.6