Skip to content

feat: add configurable escrow amount limits#487

Open
Robotron2 wants to merge 3 commits into
JSE-ORG:mainfrom
Robotron2:feat/escrow-amount-limit
Open

feat: add configurable escrow amount limits#487
Robotron2 wants to merge 3 commits into
JSE-ORG:mainfrom
Robotron2:feat/escrow-amount-limit

Conversation

@Robotron2

Copy link
Copy Markdown
Contributor

Pull Request Checklist

closes #442

Thank you for contributing! Please review the following checklist to ensure your PR is ready for review.

Summary

  • Provide a clear and concise description of the changes.
  • Link to any related issues using Fixes #issue or Related to #issue.

Testing

  • All new code is covered by unit tests where applicable.
  • Existing tests pass locally (cargo test).
  • Added tests for edge cases and error conditions.
  • Updated any integration tests if necessary.

Documentation

  • Updated README.md if changes affect users.
  • Updated docstrings/comments for new/modified functions.
  • Added examples or updated existing examples if applicable.

Code Quality

  • Follows the project's coding style and conventions.
  • No commented-out code or debug statements left in the codebase.
  • Variables and functions are named descriptively.
  • Code is properly formatted (cargo fmt).
  • No new clippy warnings (cargo clippy).

Breaking Changes

  • If this PR introduces breaking changes, describe them and provide migration steps.
  • Updated version in Cargo.toml if appropriate (following semver).

Additional Notes

  • Any other relevant information for reviewers.

Please ensure all checkboxes are checked before requesting a review.

@drips-wave

drips-wave Bot commented Jun 24, 2026

Copy link
Copy Markdown

@Robotron2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@JSE19

JSE19 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

👋 main has been fixed — und_escrow and
aise_dispute are restored and clippy is clean. Could you rebase your branch on the latest main so CI re-runs? \git rebase main\ then force-push.

@Robotron2 Robotron2 force-pushed the feat/escrow-amount-limit branch from 7eda8f0 to 1b4a4c6 Compare June 25, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add min/max escrow amount configuration

2 participants