Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos gallery #43

Open
wants to merge 2 commits into
base: src
Choose a base branch
from
Open

Videos gallery #43

wants to merge 2 commits into from

Conversation

jaydson
Copy link
Contributor

@jaydson jaydson commented Dec 23, 2014

Revision needed.
//cc @UltCombo @robsongajunior @felipenmoura

Feature: A video gallery

How to test:
Run this branch and access: http://localhost:9356/pages/videos/

@UltCombo
Copy link
Member

I assume you're also using the not-yet-merged i18n_fix branch of Harmonic? JSRocksHQ/harmonic#97

Anyway, for some reason, I can't get Harmonic to build ES6Rocks at the moment. This issue seems unrelated to this PR, but I can't test the PR without building.

@jaydson
Copy link
Contributor Author

jaydson commented Dec 23, 2014

Oh, yeah!
I'm using the fixed version of Harmonic, so i think you'll need to checkout to the branch i18n_fix, indeed.

@UltCombo
Copy link
Member

Yeah I'm using that branch, but independent of the branch, I get an error in the marked-metadata dependency whenever I try to build the ES6Rocks site.

@jaydson can you update the Harmonic dependencies to check if you will get any errors?

cd ./path/to/harmonic
rm -rf node_modules
npm link
cd ./path/to/es6rocks.github.io
harmonic build

@robsongajunior
Copy link
Contributor

I can see for us, my harmonic build it's ok. I use less-compile release hehehe
It's ok for you?

@UltCombo
Copy link
Member

I've only experienced the issue in OS X, harmonic build is working fine in my Windows environment.

Btw, nice work @jaydson !
Here's a couple suggestions:

  • The category links are not working (not sure if you intend to link them to the post categories or filter the videos or leave as is)
  • Clicking the Twitter/G+ share buttons will share the site root URL, perhaps it could share the videos gallery page URL as does the facebook button?

@UltCombo
Copy link
Member

UltCombo commented Apr 2, 2015

Is this page going to be in the new template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants