Skip to content

Changed the dragThreshold in the viewModel from one-third to one-sixth of the subview’s width #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abc2754667876 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed the dragThreshold in the viewModel from one-third to one-sixth of the subview’s width #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/ACarousel/ACarouselViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ extension ACarouselViewModel {
/// At the end of the drag, if the drag value exceeds the drag threshold,
/// the active view will be toggled
/// default is one third of subview
let dragThreshold: CGFloat = itemWidth / 3
/// Here, the original one-third has been changed to one-sixth, which, based on actual testing, results in smoother interactions.
//let dragThreshold: CGFloat = itemWidth / 3
let dragThreshold: CGFloat = itemWidth / 6

var activeIndex = self.activeIndex
if value.translation.width > dragThreshold {
Expand Down