development tooling, dependency management, and documentation by JaclynCodes · Pull Request #54 · JaclynCodes/Pretend-telegram

JaclynCodes · 2025-12-15T03:38:13Z

This pull request includes several updates to development tooling, dependency management, and documentation. The main focus is on updating the Go linter (golangci-lint) version and configuration, modernizing dependencies, and improving test and build scripts. There are also updates to licensing documentation and the addition of a new agent configuration file.

Tooling and Dependency Updates:

Updated the golangci-lint version from v2.2.1 to v1.60.1 in the GitHub Actions workflow (.github/workflows/lint.yml), lint script (script/lint), and documentation (.github/copilot-instructions.md) to ensure compatibility and stability. [1] [2] [3]
Updated the Go base image in the Dockerfile from golang:1.24.4-alpine to golang:1.25.4-alpine to use the latest Go version for builds.
Changed import of the jd library to use github.com/josephburnett/jd/lib instead of jd/v2 for consistency with dependency updates.
Updated dependency versions and references in third-party-licenses.darwin.md, including jd/lib and mark3labs/mcp-go.

Linter Configuration Improvements:

Modernized .golangci.yml by removing the obsolete version field, restructuring exclusions to use issues.exclude-dirs, exclude-files, and exclude-generated, and updating linter settings for better compatibility with newer golangci-lint versions. [1] [2]

Script and Test Fixes:

Fixed a bug in pkg/github/issues_test.go where a range loop incorrectly iterated over an integer instead of a slice, improving test reliability.
Ensured the Go binary path is included in the PATH environment variable in script/licenses and script/licenses-check for correct tool execution. [1] [2]

Documentation and Metadata:

Added a new agent configuration file .github/agents/my-agent.agent.md as a template for defining custom agents in the repository.
Added a comprehensive Ubuntu2404-Readme (1).md documenting the Ubuntu 24.04 runner environment, including installed software, tools, and environment variables.

Licensing Documentation:

Updated third-party license documentation to reflect dependency changes, removing unused packages and updating versions as needed. [1] [2]

Closes:

…orkflow Add comprehensive copilot-instructions.md for repository onboarding

…t contain permissions"

Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Created a template for a custom agent configuration. Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

- Fix jd package import to use lib subpackage - Replace range over int with traditional for loop for Go 1.23 compatibility - Update golangci-lint configuration to use modern syntax - All tests now pass and linting succeeds Co-authored-by: openhands <openhands@all-hands.dev>

Fix failing GitHub Actions

- Update golangci-lint version from v2.x to v1.60.1 in both script and workflow - Fix PATH issue in license scripts to include Go bin directory - Update third-party license files to match current dependencies Co-authored-by: openhands <openhands@all-hands.dev>

Revert "Potential fix for code scanning alert no. 1: Workflow does not contain permissions"

Bumps golang from 1.24.4-alpine to 1.25.4-alpine. --- updated-dependencies: - dependency-name: golang dependency-version: 1.25.4-alpine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

coderabbitai · 2025-12-15T03:38:18Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-12-15T03:38:37Z

Summary of Changes

Hello @JaclynCodes, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's development environment by updating core tooling and dependencies. It focuses on improving code quality through a major upgrade of the Go linter and modernizing its configuration. Additionally, it ensures the use of the latest Go version for builds, refines dependency management, and boosts the reliability of test and build scripts. The PR also expands documentation with a new agent configuration template and a comprehensive overview of the Ubuntu 24.04 runner, streamlining future development and maintenance efforts.

Highlights

Go Linter Update: Upgraded golangci-lint from v2.2.1 to v1.60.1 in the lint script and updated its configuration to a modern structure, improving code quality checks.
Go Version Update: The Dockerfile now uses golang:1.25.4-alpine as the base image, ensuring builds leverage the latest stable Go version.
Dependency Modernization: The import path for the jd library was updated to github.com/josephburnett/jd/lib, and the mcp-go dependency version was updated in third-party license documentation.
Script and Test Reliability: A bug in pkg/github/issues_test.go was fixed where a range loop incorrectly iterated over an integer. Additionally, PATH environment variables were correctly set in license generation scripts to ensure proper tool execution.
New Documentation and Configuration: A new template for custom agents (.github/agents/my-agent.agent.md) was added, along with a comprehensive Ubuntu2404-Readme (1).md detailing the Ubuntu 24.04 runner environment.
License Documentation Cleanup: References and license files for unused third-party packages, specifically golcs and golang.org/x/exp, were removed from the license documentation.

Ignored Files

Ignored by pattern: .github/workflows/** (2)
- .github/workflows/close-inactive-issues.yml
- .github/workflows/lint.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request provides a solid set of updates for development tooling, dependency management, and documentation. The modernization of the golangci-lint configuration and the update of the Go version and other dependencies are valuable improvements. I've identified a couple of minor issues in the documentation that should be addressed for accuracy and clarity. Specifically, there's an incorrect version number in the Copilot instructions and a potentially unintentional filename for the new Ubuntu runner README. Overall, these are great changes that will improve the development workflow.

.github/copilot-instructions.md

Ubuntu2404-Readme (1).md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This pull request focuses on modernizing development tooling and dependency management for the GitHub MCP Server. The changes include updating the golangci-lint version, fixing a range loop bug for Go version compatibility, updating dependency references, and adding new configuration templates.

Key changes include:

Downgrading golangci-lint from v2.2.1 to v1.60.1 with modernized configuration structure
Fixing a test bug that used Go 1.23+ range-over-integer syntax
Updating the jd library import path from v2 to lib

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`.github/workflows/lint.yml`	Updates golangci-lint version to v1.60.1
`.github/workflows/close-inactive-issues.yml`	Modifies indentation (appears to be unintentional whitespace change)
`.github/copilot-instructions.md`	Updates linter version documentation (with inconsistency)
`.github/agents/my-agent.agent.md`	Adds new agent configuration template
`.golangci.yml`	Modernizes linter configuration for v1.60.1 compatibility
`Dockerfile`	Updates Go base image version
`script/lint`	Updates golangci-lint version to v1.60.1
`script/licenses`	Adds GOPATH/bin to PATH for tool execution
`script/licenses-check`	Adds GOPATH/bin to PATH for tool execution
`pkg/github/issues_test.go`	Fixes range loop to use traditional syntax for compatibility
`internal/toolsnaps/toolsnaps.go`	Updates jd library import path
`third-party-licenses.*.md`	Updates dependency version references for jd and mcp-go
`third-party/golang.org/x/exp/LICENSE`	Removes unused dependency license
`third-party/github.com/yudai/golcs/LICENSE`	Removes unused dependency license
`third-party/github.com/josephburnett/jd/lib/LICENSE`	Adds license for updated jd library path

.github/workflows/close-inactive-issues.yml

.github/agents/my-agent.agent.md

Copilot · 2025-12-15T03:46:18Z

.github/copilot-instructions.md

   script/lint
   ```
-   This runs `gofmt -s -w .` followed by `golangci-lint run` with version v2.2.1. The linter configuration is in `.golangci.yml`.
+   This runs `gofmt -s -w .` followed by `golangci-lint run` with version v1.60.1. The linter configuration is in `.golangci.yml`.


The golangci-lint version documented here is inconsistent with the actual version being used. The script/lint file and .github/workflows/lint.yml both specify v1.60.1, but this documentation incorrectly states v2.1. This should be updated to v1.60.1 to match the actual tooling version.

@copilot open a new pull request to apply changes based on this feedback

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Copilot · 2025-12-15T03:48:16Z

@JaclynCodes I've opened a new pull request, #56, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

JaclynCodes

👍

) * Revert "Potential fix for code scanning alert no. 1: Workflow does not contain permissions" * Update stale action to specific commit version * Add custom agent template for repository Created a template for a custom agent configuration. * Update .github/copilot-instructions.md * Fix failing GitHub Actions - Fix jd package import to use lib subpackage - Replace range over int with traditional for loop for Go 1.23 compatibility - Update golangci-lint configuration to use modern syntax - All tests now pass and linting succeeds * Fix failing GitHub Actions workflows - Update golangci-lint version from v2.x to v1.60.1 in both script and workflow - Fix PATH issue in license scripts to include Go bin directory - Update third-party license files to match current dependencies * Bump golang from 1.24.4-alpine to 1.25.4-alpine (#30) Bumps golang from 1.24.4-alpine to 1.25.4-alpine. --- updated-dependencies: - dependency-name: golang dependency-version: 1.25.4-alpine dependency-type: direct:production update-type: version-update:semver-minor ... * Add files via upload * Update close-inactive-issues.yml * Onboarding (#34) (#41) * Update .github/copilot-instructions.md * Initial plan (#55) * Update .github/agents/my-agent.agent.md * Update .github/workflows/close-inactive-issues.yml * Initial plan (#56) --------- Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

JaclynCodes and others added 14 commits October 14, 2025 16:47

Merge pull request #26 from JaclynCodes/copilot/add-codeql-analysis-w…

428c8a0

…orkflow Add comprehensive copilot-instructions.md for repository onboarding

Revert "Potential fix for code scanning alert no. 1: Workflow does no…

a29ac23

…t contain permissions"

Update stale action to specific commit version

960aac3

Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Add custom agent template for repository

5da70d0

Created a template for a custom agent configuration. Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Update .github/copilot-instructions.md

530dced

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Merge pull request #36 from JaclynCodes/fix-github-actions-failures

de1e104

Fix failing GitHub Actions

Merge branch 'Master' into revert-12-alert-autofix

7f0cdc7

Merge pull request #31 from JaclynCodes/revert-12-alert-autofix

c79a397

Revert "Potential fix for code scanning alert no. 1: Workflow does not contain permissions"

Add files via upload

ae0e860

Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Update close-inactive-issues.yml

7f129eb

Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Onboarding (#34) (#41)

03b309d

Copilot AI review requested due to automatic review settings December 15, 2025 03:38

JaclynCodes assigned Copilot and JaclynCodes Dec 15, 2025

Copilot started reviewing on behalf of JaclynCodes December 15, 2025 03:38 View session

gemini-code-assist bot reviewed Dec 15, 2025

View reviewed changes

.github/copilot-instructions.md Outdated Show resolved Hide resolved

Ubuntu2404-Readme (1).md Show resolved Hide resolved

coderabbitai bot approved these changes Dec 15, 2025

View reviewed changes

JaclynCodes and others added 2 commits December 14, 2025 22:41

Update .github/copilot-instructions.md

3234345

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Initial plan (#55)

a3a2145

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI reviewed Dec 15, 2025

View reviewed changes

JaclynCodes and others added 2 commits December 14, 2025 22:47

Update .github/agents/my-agent.agent.md

7e03eef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Update .github/workflows/close-inactive-issues.yml

6d71b48

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Misfit <218383634+JaclynCodes@users.noreply.github.com>

Copilot AI mentioned this pull request Dec 15, 2025

[WIP] Update development tooling and documentation based on feedback #56

Merged

Initial plan (#56)

4cc3a35

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

JaclynCodes commented Dec 15, 2025

View reviewed changes

JaclynCodes merged commit 2dc2c0f into copilot/add-codeql-analysis-workflow Dec 15, 2025
6 of 24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

development tooling, dependency management, and documentation#54

development tooling, dependency management, and documentation#54
JaclynCodes merged 19 commits intocopilot/add-codeql-analysis-workflowfrom
main

JaclynCodes commented Dec 15, 2025

Uh oh!

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot commented Dec 15, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 15, 2025

Uh oh!

JaclynCodes Dec 15, 2025

Uh oh!

Copilot AI commented Dec 15, 2025

Uh oh!

JaclynCodes left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

JaclynCodes commented Dec 15, 2025

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot commented Dec 15, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

JaclynCodes Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 15, 2025

Uh oh!

JaclynCodes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Dec 15, 2025 •

edited

Loading