-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #178 and bump version to 2.1.1 #179
base: master
Are you sure you want to change the base?
Conversation
Removed utf-8 encoding step as recommended in JakeWharton#97 (comment). This is backwards-compatible with Python 2.
Fixed color encoding problem causing Issue JakeWharton#178
Version increases to 2.1.1 to cover fixes for Issues JakeWharton#147 and JakeWharton#178.
(Forgive my ignorance with python) Does this change require usage of python3? If so why not update to python3 in pidcat.py? At least on the latest version of MacOS 12.3 pidcat will not run due to the removal of python2. The file But now noticing that the package filtering doesnt work either when using python3 |
I tried this change on Python 2.7.18, and it seemed to work fine. |
I guess I could install python2 to the Mac again. Marcos 12.3 removed it by default. |
AFAICT, the current version of the script should work in either python2 or
python3.
…On Fri, Mar 25, 2022 at 3:38 PM Brad Barnhill ***@***.***> wrote:
I guess I could install python2 to the Mac again. Marcos 12.3 removed it
by default.
—
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZ34VS7NKR555WBPFZX663VBY55NANCNFSM5QHKSMNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
With python3 the package filter was not working for me. |
Maybe you should change first line like this: and the last line like this: |
No description provided.