Repository navigation
refactor(update_dois): drop the orphaned add_pmid function - #530
Merged
Merged
Conversation
The last call to add_pmid went away in 53952c1 ("Removed PMID update", 2025-06-18), but the function itself stayed behind. Nothing has called it since, and nothing imports it. PMID population is not lost: sync_pmid_to_dois.py does that work with its own JRC.get_pmid call. The 'add_pmid' string in that file is a processing-event action label and is unrelated to this function. No behavior change. JRC and terminate_program, the two names the function used, are still used throughout the module. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last call to add_pmid went away in 53952c1 ("Removed PMID update", 2025-06-18), but the function itself stayed behind. Nothing has called it since, and nothing imports it.
PMID population is not lost: sync_pmid_to_dois.py does that work with its own JRC.get_pmid call. The 'add_pmid' string in that file is a processing-event action label and is unrelated to this function.
No behavior change. JRC and terminate_program, the two names the function used, are still used throughout the module.