-
Notifications
You must be signed in to change notification settings - Fork 1
v12.0.0 Uv install python #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactor Python installation logic to support zstandard extraction and improve error handling.
Refactor Python installer to optimize performance and caching
to avoid possible blocking
Refactored Python version compatibility checks to use a centralized function for better maintainability and clarity.
Caution Review failedThe pull request is closed. Walkthrough
Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor App as Caller
participant GP as get-python.js
participant PATH as System PATH
participant UV as UV Installer
participant Sh as OS Shell
participant Py as Python
rect rgb(236,248,255)
note over GP: Discovery phase (changed)
App->>GP: findPythonExecutable()
GP->>PATH: Iterate candidates (python, python3, etc.)
PATH-->>GP: Candidate paths
GP->>Sh: Invoke candidate --version
Sh-->>GP: Version output
alt Compatible (3.10–3.13)
GP-->>App: Return existing Python path
else Not found
note over GP,UV: Installation phase via UV (new)
GP->>UV: isUVAvailable()
alt UV missing
GP->>Sh: installUV (PowerShell or curl)
Sh-->>GP: UV installed
end
GP->>UV: Install Python 3.13.x into destination
UV-->>GP: Installation result
GP->>GP: ensurePythonExeExists()
GP->>Sh: Verify python --version
Sh-->>GP: 3.13.x confirmed
GP-->>App: Return installed Python path
end
end
note over App,GP: Errors collected and surfaced (incl. distutils-related)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Refactor
Chores
Misc