Build system improvements #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #329
nathanwbrei
force-pushed
the
nbrei_small_improvements
branch
from
6fb343c
to
1dafbc7
Compare
- Plugin libraries install to lib/JANA/plugins/ - Plugin headers install to include/JANA/plugins/$PLUGIN_NAME Addresses issue #136
Eventually we should put this in the rpath if possible
This is for consistency with installing plugins, etc. This is also on CMake's search path, so there should be no effect downstream.
nathanwbrei
force-pushed
the
nbrei_small_improvements
branch
6 times, most recently
from
0c2953b
to
acc3538
Compare
nathanwbrei
force-pushed
the
nbrei_small_improvements
branch
from
b276154
to
ec0959e
Compare
nathanwbrei
force-pushed
the
nbrei_small_improvements
branch
from
c75c2f5
to
b7827a6
Compare
Even though podio is in the RPath, Cling won't look there when hunting for libpodio's dictionaries
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<prefix>/pluginsmay lead to conflicts #136)<prefix>/pluginsmay lead to conflicts #136)add_jana_pluginandadd_jana_testCMake macros to enforce consistent linking and installationctesttest suite in order to run smoke tests, unit tests, and integration tests via a unified interface