Bugfix: JFactory::Finish #377

nathanwbrei · 2024-10-23T15:45:00Z

This PR includes several bugfixes:

JFactory::Finish() wasn't getting called
The final JFactory::EndRun() wasn't getting called
JFactory::BeginRun() was getting called spuriously when no run number was set
JParameterManager::SetDefaultParameter() with conflicting defaults had an edge case where they use the wrong default value

This PR adds:

This PR includes several refactorings:

Event clearing and finishing logic is now encapsulated on the JEvent itself instead of the JEventPool
JEvents are automatically configured when the constructor is passed a JApplication

The old name means something very different in the other context of other JComponents.

nathanwbrei added 17 commits October 20, 2024 23:42

Test behavior of exceptions in JFactory::Init

5dc2b15

Test cases: Assert non-null m_app

c8faae5

JEvent now configures itself when passed JApplication

532649b

Move methods into JEvent.cc

28dc617

Reorganize JEvent.h

a8bf670

Test cases no longer call JComponentManager::configure_event

d53da0b

JFactory::EndRun() and Finish() called correctly

f44ebf3

Move event clearing and finishing logic into JEvent::Clear, Finish

9c772d5

Rename JEventSource::DoFinish to DoFinishEvent

7acda8c

The old name means something very different in the other context of other JComponents.

JFactory::Finish tests

3bf9862

Test cases for JFactory::{BeginRun,Process,EndRun,Finish}

0a4fb82

Test callback sequence for JEventProcessors

e37175f

Bugfix: JParameter registration with conflicting defaults

e4b76ab

Add "Conflicting defaults" warning to PrintParameters()

3505b51

Add "jana:show_ticker" parameter

7bf1db2

Improve parameter summary

768cdbd

Document jana:show_ticker parameter

5f63b12

nathanwbrei merged commit ba511e3 into master Oct 23, 2024
9 checks passed

nathanwbrei deleted the nbrei_jfactory_finish branch October 23, 2024 16:36

Provide feedback