Skip to content

Reject a deploy request without a version #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slominskir merged 1 commit into from
Oct 1, 2026
Merged

Reject a deploy request without a version #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jlab/adm/business/session/DeployerFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ private void validateSemver(String ver) throws UserFriendlyException {
"^(0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?$";
final Pattern p = Pattern.compile(regex);

if (!p.matcher(ver).matches()) {
if (ver == null || !p.matcher(ver).matches()) {
throw new UserFriendlyException("Version string must be semver formatted");
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/test/java/org/jlab/adm/business/session/DeployerFacadeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import org.jlab.smoothness.business.exception.UserFriendlyException;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.NullSource;
import org.junit.jupiter.params.provider.ValueSource;

class DeployerFacadeTest {
Expand Down Expand Up @@ -87,8 +88,10 @@ void semverIsAccepted(String version) throws Exception {
assertEquals(version, started.get(0).getVersion());
}

// The version is appended to the deploy command run in a shell, so anything else is rejected
// The version is appended to the deploy command run in a shell, so anything else is rejected.
// Null is a request without the ver parameter.
@ParameterizedTest
@NullSource
@ValueSource(
strings = {
"",
Expand Down
Loading