Repository navigation
Land the Keycloak wait fix and configurable ports on main - #27
Merged
Merged
Conversation
awaitReady retried only I/O and runtime exceptions, but a failed token request is an assertion error, so the tests failed at once while Keycloak was still creating the test realm. Retry those too, and wait for the admin's password login, which works only once Keycloak's last setup script has run: the service account's login works earlier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two copies of the stack, or adm and another project, could not run at once on one machine: every host port was fixed, and so was every container name. Each published port now comes from an ADM_*_PORT variable, which docker compose reads from the environment or from .env, defaulting to the port it used before. Keycloak's frontend URL and redirect URIs, and the app's KEYCLOAK_FRONTEND_SERVER_URL and FRONTEND_SERVER_URL, follow ADM_KEYCLOAK_PORT and ADM_HTTPS_PORT, so logins and token issuers match the ports in use. The services no longer set container_name, so Compose names containers, network, and images after the project directory (adm-oracle-1 and so on), and a copy in a git worktree gets its own. The integrationTest task passes the ADM_* variables in .env to the tests, which build their default URLs from ADM_HTTPS_PORT and ADM_KEYCLOAK_PORT. The README lists the variables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slominskir
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings two changes to
mainthat were merged into theintegration-testsbranch instead:main.main. It was merged intointegration-tests.The certificate fix (48e22e2) did make it into #24's squash, so it's not repeated here. With this PR,
mainmatches theintegration-testsbranch.Commits
awaitReadygave up on the first token request ({"error":"Realm does not exist"}, 404) while Keycloak was still creating the test realm. The token failure is an assertion error, which wasn't retried. The check now also waits for the admin's password login, which works only after Keycloak's last setup script has run.Checks
./gradlew spotlessCheck build integrationTestagainst the running stack: 45 tests pass (33 unit, 12 integration).pki.jlab.org, and the images build in about 1.5 minutes. The only failure was this one.After merging, #25's integration job should pass once its branch is updated with
main.🤖 Generated with Claude Code