Repository navigation
Momentum magnitude for forward tracks, estimated by AI, needs to be scaled by the scale factor of magnetic field - #1541
Open
tongtongcao wants to merge 1 commit into
Open
tongtongcao wants to merge 1 commit into
tongtongcao wants to merge 1 commit into
Conversation
…caled by the scale factor of magnetic field
raffaelladevita
requested changes
Oct 26, 2026
| initSV.Q = estSV[4]; | ||
|
|
||
| double absTorScale = Math.abs(Swimmer.getTorScale()); | ||
| if(absTorScale != 1 && absTorScale != 0) |
Collaborator
There was a problem hiding this comment.
why excluding 1? and why just not replacing line 257
Collaborator
Author
There was a problem hiding this comment.
Just in case that scale = 0 as denominator. Not need to scale if 1.
Collaborator
There was a problem hiding this comment.
what about replacing line 257 with
initSV.Q = absTorScale!=0 ? estSV[4]/absTorScale : estSV[4]
or even better
initSV.Q = absTorScale>0.001 ? estSV[4]/absTorScale : estSV[4]
since 0.001 is used elsewhere in the code as the value below which straight tracks are used
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI model for estimation of HB track states was trained through data samples with magnetic field scale factor as 1. Correspondingly, the predicted momentum magnitude needs to be scaled by the magnetic filed scale factor when the model is applied into reconstruction for data with other scale factor of magnetic field.
As Raffaella's test, it should be the reason, that cause KPP test failed in PR#1491