Repository navigation
Pin the Docker base images - #52
Merged
Merged
Conversation
The image used tomcat:11-jdk21 and gradle:9-jdk21-alpine, so each build took whatever versions were newest. Tests ran against Tomcat 11.0.26 while production runs 11.0.10, and the image was built with Gradle 9.8 while the wrapper, used locally and in CI, pins 9.0.0. Pin tomcat:11.0.26-jdk21, the latest Tomcat 11 and what the tests already ran on, and gradle:9.0.0-jdk21-alpine, matching the wrapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slominskir
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile used
tomcat:11-jdk21andgradle:9-jdk21-alpine, so each build took whatever versions were newest at the time:This pins:
tomcat:11.0.26-jdk21, the latest Tomcat 11 release and what the tests already ran on;gradle:9.0.0-jdk21-alpine, matchinggradle-wrapper.properties.Tomcat changes since 11.0.10 that matter for epics2web
From the Tomcat 11 changelog, WebSocket sections:
WEBSOCKET_SEND_TIMEOUT_SECONDS).permessage-deflate, which browsers negotiate by default. These are on the receiving side, and client-to-server messages are small, so less likely to matter.IOExceptioninstead ofIllegalStateException. epics2web already catches both.The 16 patch releases also include security and connector fixes outside WebSocket.
Deployment
Production installs Tomcat separately, so this doesn't change it. Moving production from 11.0.10 to 11.0.26 would match what's tested.
Checks
With the pinned images:
Keeping pins current
The repository has no Dependabot configuration, so these pins will only change when someone updates them. A
.github/dependabot.ymlcovering thedockerandgradleecosystems would open pull requests for new versions. I can add that separately if you'd like.🤖 Generated with Claude Code