Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Conversation

@BlueRaja
Copy link
Collaborator

I created a NuGet package for SteamAuth here. This PR updates SteamBot to use it.

This should fix the troubles people have been having with the submodule (eg. #897)

@waylaidwanderer
Copy link

It would be better if @geel9 or @Jessecar96 were the ones to do it, but since they haven't...

Looks good to me, except for one thing.

SteamBot.sln Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this stop users from being able to open the solution in anything older than Visual Studio 14? I remember that being an issue before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but I don't have VS 2013 to test with. Can anyone here test it?

@BlueRaja
Copy link
Collaborator Author

In the SteamAuth PR I offered to add them both as owners, so they can push new versions when needed.

@BlueRaja
Copy link
Collaborator Author

Updated to the latest version of SteamAuth, and reverted the change called out by @waylaidwanderer above.

Has anyone else attempted to test this yet?

@Bottswana
Copy link
Contributor

I tried it recently and couldn't get it to work, but it might just be a bad
merge with my tree. I did only look at it for 5 minutes. Will have a
further look tomorrow
On 27 Jan 2016 12:21 a.m., "BlueRaja" [email protected] wrote:

Updated to the latest version of SteamAuth, and reverted the change called
out by @waylaidwanderer https://github.com/waylaidwanderer above.

Has anyone else attempted to test this yet?


Reply to this email directly or view it on GitHub
#913 (comment).

This was referenced Jan 28, 2016
@BlueRaja BlueRaja mentioned this pull request Feb 6, 2016
@BlueRaja BlueRaja mentioned this pull request Feb 13, 2016
@scholtzm
Copy link
Contributor

Just merge this. I can't imagine this causing more trouble than the current state.

@BlueRaja
Copy link
Collaborator Author

Yeah, that's probably a good idea. We've had enough "Jsonsoft.dll can't be found" issues...

BlueRaja added a commit that referenced this pull request Feb 14, 2016
@BlueRaja BlueRaja merged commit 046258a into Jessecar96:master Feb 14, 2016
@BlueRaja BlueRaja deleted the UseNugetSteamAuth branch February 14, 2016 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants