-
Notifications
You must be signed in to change notification settings - Fork 898
Use NuGet SteamAuth #913
Use NuGet SteamAuth #913
Conversation
|
It would be better if @geel9 or @Jessecar96 were the ones to do it, but since they haven't... Looks good to me, except for one thing. |
SteamBot.sln
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this stop users from being able to open the solution in anything older than Visual Studio 14? I remember that being an issue before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, but I don't have VS 2013 to test with. Can anyone here test it?
|
In the SteamAuth PR I offered to add them both as owners, so they can push new versions when needed. |
c903464 to
482084f
Compare
|
Updated to the latest version of SteamAuth, and reverted the change called out by @waylaidwanderer above. Has anyone else attempted to test this yet? |
|
I tried it recently and couldn't get it to work, but it might just be a bad
|
|
Just merge this. I can't imagine this causing more trouble than the current state. |
|
Yeah, that's probably a good idea. We've had enough "Jsonsoft.dll can't be found" issues... |
I created a NuGet package for SteamAuth here. This PR updates SteamBot to use it.
This should fix the troubles people have been having with the submodule (eg. #897)