Adjust BTF2 tap behavior to BTF1 on iOS #1923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementing custom iOS behavior
…InputBtf2` in SelectionGestures.kt
mazunin-v-jb
changed the title
| dragBeginPosition = Offset.Unspecified | ||
| dragTotalDistance = Offset.Zero | ||
| textFieldSelectionState.directDragGestureInitiator = InputType.None | ||
| requestFocus() |
There was a problem hiding this comment.
Suggested change
| requestFocus() | |
| requestFocus() | |
| textFieldSelectionState.clearHandleDragging() |
Required for magnifier to work
| textFieldSelectionState.textLayoutState.fromDecorationToTextLayout(coercedOffset) | ||
| ) | ||
| } | ||
| textFieldSelectionState.showCursorHandle = true |
There was a problem hiding this comment.
Suggested change
| textFieldSelectionState.showCursorHandle = true | |
| textFieldSelectionState.showCursorHandle = true | |
| textFieldSelectionState.updateHandleDragging(Handle.Cursor, startPoint) |
| // as it does with a single tap | ||
| textFieldSelectionState.placeCursorAtNearestOffset( | ||
| textFieldSelectionState.textLayoutState.fromDecorationToTextLayout(coercedOffset) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| textFieldSelectionState.updateHandleDragging(Handle.Cursor, currentDragPosition) |
Open
ASalavei
requested changes
Mar 17, 2025
| private var density: Density, | ||
| private var enabled: Boolean, | ||
| private var readOnly: Boolean, | ||
| var enabled: Boolean, |
| } | ||
|
|
||
| /** Runs platform-specific text selection gestures logic. */ | ||
| internal expect suspend fun PointerInputScope.getTextFieldSelectionGestures( |
There was a problem hiding this comment.
This one should be also implemented in the android target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in BTF2:
Added iOS-like tap behavior
Added iOS-like long-tap behavior
Added iOS-like double and triple taps selection
Added context menu calling in BTF2
Fixes: https://youtrack.jetbrains.com/issue/CMP-628
Testing
Manually, should be tested by QA
Release Notes
Features - iOS
Added native behavior for tap, long tap and multiple tap to
BasicTextField(TextFieldState).