forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 105
CMP-9264 Expose showLayoutBounds API on ComposePanel #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rock3r
wants to merge
1
commit into
JetBrains:jb-main
Choose a base branch
from
rock3r:sebp/add-showLayoutBounds-api
base: jb-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Nov 12, 2025
Member
MatkovIvan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature freeze for 1.10 has already happened, blocking until we create a release branch
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeContainer.desktop.kt
Outdated
Show resolved
Hide resolved
cae0284 to
f41302c
Compare
Author
|
Thanks @MatkovIvan for the help making this better :) |
MatkovIvan
reviewed
Nov 12, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeScene.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Show resolved
Hide resolved
fdfc226 to
08b2853
Compare
igordmn
requested changes
Nov 12, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Outdated
Show resolved
Hide resolved
515704a to
7d69010
Compare
igordmn
approved these changes
Nov 12, 2025
MatkovIvan
reviewed
Nov 19, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindow.desktop.kt
Show resolved
Hide resolved
This exposes a showLayoutBounds property on ComposePanel (desktop only) that allows users to turn on or off the showLayoutBounds property on the root layout node owner(s). The change mostly pipes the property up to the ComposePanel, but has no public API impact. The new property is also annotated as experimental. The Skiko RootNodeOwner's showLayoutBounds is now also a state, to cause a full recomposition when the value changes and see it reflected in the UI.
7d69010 to
9ea8218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a
showLayoutBoundsproperty onComposePanel(desktop only) that allows users to turn on or off theshowLayoutBoundsproperty on the root layout node owner(s).The change mostly pipes the property up to the
ComposePanel, but has no public API impact. The new property is also annotated as experimental. The SkikoRootNodeOwner'sshowLayoutBoundsis now also a state, to cause a full recomposition when the value changes and see it reflected in the UI.Screen.Recording.2025-11-12.at.13.04.16.mov
Fixes https://youtrack.jetbrains.com/issue/CMP-9264/Expose-API-on-ComposePanel-to-toggle-showLayoutBounds
Testing
Manual testing as it's not automatable:
Release Notes
N/A