Migrate window insets padding modifiers from composed API to InsetsPaddingModifierNode
#2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddingModifierNode
ASalavei
reviewed
Nov 13, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
Outdated
Show resolved
Hide resolved
…otNodeOwner.skiko.kt Co-authored-by: Andrei Salavei <[email protected]>
ASalavei
reviewed
Nov 13, 2025
...ui/ui/src/uikitInstrumentedTest/kotlin/androidx/compose/ui/layout/WindowInsetsPaddingTest.kt
Show resolved
Hide resolved
ASalavei
requested changes
Nov 13, 2025
ASalavei
left a comment
ASalavei
left a comment
There was a problem hiding this comment.
Please update release note - the PR not only fixes things, but also adds support for the new API
…d to compose scene
ASalavei
reviewed
Nov 14, 2025
...se/ui/ui/src/uikitInstrumentedTest/kotlin/androidx/compose/ui/keyboard/KeyboardInsetsTest.kt
Show resolved
Hide resolved
ASalavei
approved these changes
Nov 14, 2025
MatkovIvan
requested changes
Nov 14, 2025
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
API/features for 1.10 is already frozen. Blocking until creating a release branch
| assertEquals(expected = frame?.bottom, actual = screenSize.height - keyboardHeight) | ||
| } | ||
|
|
||
|
|
| } | ||
|
|
||
| @OptIn(InternalComposeUiApi::class) | ||
| fun DelegatableNode.requireWindowInsets(): PlatformWindowInsets { |
Member
There was a problem hiding this comment.
Why do we need it as public (and stable) API?
|
|
||
| import androidx.compose.runtime.Stable | ||
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.runtime.setValue |
Member
There was a problem hiding this comment.
Changes in common. Do we have a task to upstream diff in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates window insets padding modifiers from composed API to
InsetsPaddingModifierNode. ProvidesPlatformWindowInsetsthrough the root node modifier to child nodes required for creating window insets padding modifiers.Fixes CMP-8953 Migrate non-Android Insets Padding Modifiers away from "Composed" API to "Modifier.Node"
Fixes CMP-8998 Migrate insets modifiers to
InsetsPaddingModifierElementFixes CMP-9201 ModalBottomSheet padding interaction on iOS in CMP 1.10.0-alpha03
Testing
Adds test of recomposition behavior to
WindowInsetsPaddingTestsTested by existing tests
Release Notes
Fixes - iOS
Features - Multiple Platforms
InsetsPaddingModifierNode