refactor: removed usless toHex functions #5510
Open
+1
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y9san9
requested review from
a team,
fzhinkin,
ilya-g and
qwwdfsad
as code owners
y9san9
commented
Sep 27, 2025
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Sorry for that.
I have this setting to add newlines to the end of files enabled. Can remove that change if that's something critical.
adam-enko
reviewed
Sep 29, 2025
| return File(cacheDirectory, computeDependenciesHash(dependency, resolvedConfiguration, partialLinkageMode)) | ||
| } | ||
|
|
||
| internal fun ByteArray.toHexString() = joinToString("") { (0xFF and it.toInt()).toString(16).padStart(2, '0') } |
There was a problem hiding this comment.
Kotlin Gradle plugin has to use a Kotlin language level of 1.4, because KGP has to be compatible with its lowest supported Gradle version, which is 7.6.
https://docs.gradle.org/current/userguide/compatibility.html
This means code in libraries/tools/kotlin-gradle-plugin/ can't use the new ByteArray.toHexString util, which was added as experimental in Kotlin 1.9.
There was a problem hiding this comment.
That's fair, thank you. Added this one back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have this in stdlib, let's use that :)
Hope nothing've broken, as far as I see the logic should be the same.
Just doing some choirs.