Open
Conversation
Salomon88
reviewed
May 12, 2025
| override fun execute(urlDecoder: QueryStringDecoder, request: FullHttpRequest, context: ChannelHandlerContext): String? { | ||
| val path = urlDecoder.path().split(serviceName).last().trimStart('/') | ||
| val project = getLastFocusedOrOpenedProject() ?: return null | ||
|
|
Salomon88
reviewed
May 13, 2025
| @Serializable | ||
| object NoArgs | ||
|
|
||
| interface ProjectAware { |
There was a problem hiding this comment.
Can you please provide a java doc for this interface? This is needed to better understand the meaning behind this interface
Salomon88
reviewed
May 14, 2025
| @Serializable | ||
| data class PropertySchema( | ||
| val type: String | ||
| val type: String, |
|
Any update on this getting merged - probably the biggest impact issue with this MCP. As it prevents using multiple projects at once |
Author
|
@hjed you can fix =) (do you?) |
|
Have the review comments done on a branch master...hjed:mcp-server-plugin:project-aware but haven't had chance to test more extensively |
Closed
|
after testing have now raised an updated pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems this work for me on demo project. Will check it at work (I had issues with multiple projects/modules).