chore(appkit): kill dead native ask/agent surface; align URL bar - #12
Merged
Merged
Conversation
…cons Remove worker/session/page-info commands with no UI, unused mobile/Windows icon trees, and stale Swift/Xcode leftovers. Navigation now waits through TauriBrowserRuntime; Vite defaults to the desktop entry only. Co-authored-by: Jimthetaxguy <Jimthetaxguy@users.noreply.github.com>
Remove tauri-plugin-shell from the lockfile and drop generated ACL entries for get_page_info, list_sessions, list_workers, and get_worker. Co-authored-by: Jimthetaxguy <Jimthetaxguy@users.noreply.github.com>
Drop the dead AppKit `ask` case and stop posting unused agent commands that only hit "Unhandled native command". Native URL entry now follows the same first-stage http(s) parse rules as Tauri validate_url instead of falling back to Google search. Co-authored-by: Jimthetaxguy <Jimthetaxguy@users.noreply.github.com>
Jimthetaxguy
marked this pull request as ready for review
September 12, 2026 08:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b6ccee227
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused native agent/ask messaging surface and align the AppKit address bar with its URL-only behavior. The placeholder now asks for a URL or domain. Integrate the current Tauri shell cleanup, generated-resource packaging, and headless policy-stub documentation and argument validation.
Validation: full Rust/frontend verifier passes, including the 12 headless tests and locked cargo checks. The native Xcode build succeeds with signing disabled; the generated control assets match the app bundle byte-for-byte, and the generated ACL matches the 20 actual Tauri commands. The URL-hint review finding is addressed and resolved.