fix(policy): block navigate in ReadOnly; trim crate description - #13
Open
Jimthetaxguy wants to merge 1 commit into
Open
fix(policy): block navigate in ReadOnly; trim crate description#13Jimthetaxguy wants to merge 1 commit into
Jimthetaxguy wants to merge 1 commit into
Conversation
ReadOnly previously allowed ToolAction::Navigate, which contradicts SKILL.md and AGENT-SURFACE.md. Drop it from the Allow set so it Blocks with ReadOnlyMode. Add a regression test. Trim the root crate description to the shipped library (scraper + agent), not a custom renderer. Drop the changelog sentence on the HTML injection scan. Co-authored-by: Jimthetaxguy <Jimthetaxguy@users.noreply.github.com>
Jimthetaxguy
marked this pull request as ready for review
September 12, 2026 08:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny honesty pass on
main. Aligns the ReadOnly policy with SKILL.md /docs/AGENT-SURFACE.mdand trims crate metadata to the shipped library.Changes
navigate.src/agent/policy.rspreviously allowedToolAction::Navigatein the ReadOnly arm. Docs say Block. Drop it from the Allow set so it falls through toBlock+ReadOnlyMode.tests/action_policy.rs:readonly_mode_blocks_navigate. Existing tests did not assert Allow.Cargo.toml: no longer claims a custom rendering engine. Now “HTTP scraper and policy-gated browser agent library.”text.or(html)short-circuit.Out of scope
ToolAction/ scaffolding cleanup (held until chore(agent): delete unused Rust core scaffolding #5)src-tauri// Swift / docsProof
Ran locally on Rust 1.98.1:
cargo test --all-targets --locked— pass (includingreadonly_mode_blocks_navigate)cargo clippy --all-targets --locked -- -D warnings— passsrc/agent/policy.rs,tests/action_policy.rs, and rootCargo.toml