Port effect-playwright to Effect v4 RC - #25
Merged
Merged
Conversation
commit: |
fiws
force-pushed
the
push-effect-v4-rc
branch
from
August 21, 2026 08:54
acc613d to
f3bbe5a
Compare
fiws
force-pushed
the
push-effect-v4-rc
branch
from
August 21, 2026 08:56
f3bbe5a to
e38f642
Compare
StefanWerW
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
effectand@effect/vitestto4.0.0-rc.111Verification
pnpm checkpnpm type-checkpnpm buildpnpm test(101 passed)pnpm test:playwright(12 passed, 2 skipped)pnpm check-doc-examples(31 examples)pnpm coverageNote
High Risk
This is a breaking peer-dependency jump from Effect 3 to Effect 4 RC, rewriting public service tags, streams, Options, and test helpers. Consumers on Effect 3 will not compile or run against this release.
Overview
Breaking: the peer dependency is now
effect@^4.0.0-rc.111(with matching@effect/vitest).@effect/platformis no longer a peer.Service tags switch from
Context.GenericTag/Context.TagtoContext.Service. Event streams useStream.callback+Queueinstead ofStream.asyncPush. Nullable Playwright values useOption.fromNullishOr/liftNullishOr. PageexposeFunction/exposeEffectrun viaEffect.runPromiseWithon captured context.Tests move from
it.scopedtoit.effect,Effect.forkChild, and array-based collect results (noChunk). The coverage script no longer uses@effect/cli/ platform-node. The Playwright test helper builds layers withLayer.buildWithMemoMapandLayer.effectfor scoped services.Reviewed by Cursor Bugbot for commit e38f642. Bugbot is set up for automated code reviews on this repo. Configure here.