Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding change to support use of special characters in command line prompts #22

Open
wants to merge 3 commits into
base: patch-1
Choose a base branch
from

Conversation

REsteche
Copy link

I just changed the coding from 'utf-8' to 'latin_1' to make the lib capable of handling special characters.

@Joeclinton1
Copy link
Owner

How can I test this to make sure it works?

@REsteche
Copy link
Author

REsteche commented Aug 30, 2022

I tested it for several English words and the behavior remains exactly the same, but for Portuguese words that contain special characters like "caça" or "maçã", the code only started working when I changed the encoding to Latin-1. If you're interested, I can recommend a list of other words in Portuguese/English for you to check out - to get access to the modified code, just clone my repository and run the test script in the same directory :)

@mrclean789
Copy link

I implemented your changes but it doesn't work quite right, for e.g. for
ramírez
it prints
ramírez

This edit worked for me.

@REsteche
Copy link
Author

REsteche commented Oct 2, 2022

I implemented your changes but it doesn't work quite right, for e.g. for ramírez it prints ramírez

This edit worked for me.

Thanks for letting me know, @mrclean789! I will adapt it soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants