Skip to content

Adding changes to load models with complex objects #14684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: migration/scala213
Choose a base branch
from
Open

Adding changes to load models with complex objects #14684

wants to merge 12 commits into from

Conversation

@danilojsl
Copy link
Contributor

@danilojsl danilojsl commented Nov 3, 2025

Description

Adding changes to load models with complex objects. The change is being tested with EntityRuler annotator

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

DevinTDHa and others added 11 commits June 3, 2025 15:45
@DevinTDHa
Switch to Java 11 and Scala 2.13.16
772361b
@DevinTDHa
WIP: Scala 2.13 changes to compile
75d5d19
@DevinTDHa
Add mechanism for legacy serialized objects
89c57e1 
Introduces the LegacyObjectInputStream to load objects, that were
serialized in Scala 2.12

- Replacement for HashMap Serialization Proxy
- Replacement for List deserialization
@DevinTDHa
Replace deprecated replaceAllLiterally
38cbe71
@DevinTDHa
Fix tests for Scala 2.13
cbbed3d 
- Explicit mutable sequences to numerous tests
- ViT: Lazy model for test
- Fix PerceptronApproach MapView
@DevinTDHa
ContextSpellChecker: fix unpredictable behavior of mutable.HashMap mo…
0139bd2 
…dification

genVocab would not iterate over all vocab in the mutable.HashMap. This is due to
the iterator state of the mutable.HashMap being changed during iteration. Fixed by
using mapValuesInPlace.
@DevinTDHa
WIP: Transducer legacy deserialization
05a5c5e
@DevinTDHa
All FastTests passing in Scala 2.13
fa0547b 
- protected features: fix no captured input during test
@DevinTDHa
Restore llama and openvino dependencies
94ce26d
@DevinTDHa
Dependency: Adjust tf to 2.12
41ae0fa
@danilojsl
Adding changes to load models with complex objects
4955483
@danilojsl danilojsl requested a review from DevinTDHa November 3, 2025 14:57
@danilojsl danilojsl marked this pull request as ready for review November 3, 2025 14:57
@danilojsl danilojsl force-pushed the migration/scala213-loading-complex-objects branch from b7fc33e to 251aeb0 Compare November 3, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DevinTDHa DevinTDHa Awaiting requested review from DevinTDHa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danilojsl @DevinTDHa