This repository was archived by the owner on Oct 30, 2020. It is now read-only.
Implemented "showFromRect:inView:animated:"#24
Open
michaeltyson wants to merge 2 commits intoJonasGessner:masterfrom
Open
Implemented "showFromRect:inView:animated:"#24michaeltyson wants to merge 2 commits intoJonasGessner:masterfrom
michaeltyson wants to merge 2 commits intoJonasGessner:masterfrom
Conversation
This adds the ability to select an origin rect, and have JGActionSheet automatically determine which side to display on. This mirrors the functionality from UIActionSheet.
Owner
|
Awesome, this is something I wanted to implement a long time ago. I'll test it when I get some free time but it looks promising! Wicked! |
Author
|
Cool =) |
This provides the equivalent behaviour to moveToPoint..., but automatically selects the arrow direction and anchor point.
Author
|
Just added an additional commit that provides the "moveToRect" functionality necessary when rotating |
|
I would love to get this pull-requested merged and the pod updated. Thanks @michaeltyson for implementing it. |
Owner
|
Thanks for reminding me. I'm super busy but I hope that I will be able to test this soon. |
Author
|
Ah, the downside of getting pull requests - yet another thing to add to the todo list =) I've always got a backlog on my projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This adds the ability to select an origin rect, and have JGActionSheet automatically determine which side to display on. This mirrors the functionality from UIActionSheet.