Add pill editor interactivity on top of arena quick-info split - #1
Open
JonathanEspinosaLong wants to merge 7 commits into
Open
Add pill editor interactivity on top of arena quick-info split#1JonathanEspinosaLong wants to merge 7 commits into
JonathanEspinosaLong wants to merge 7 commits into
Conversation
Add an optional onTap to DeltaChip (ink ripple over the pill) and wire the commander-damage pill so tapping it selects the commander that dealt the damage as the attacker and sets that attacker's active partner to match the pill, entering commander-damage mode.
Tapping a numeric counter or commander-cast quick-info pill now takes over the cell with a centered +/- editor floating over the commander art: the rest of the cell UI fades out and the control animates in as if the pill repositions itself from its corner. - PillFocus model + a focusedPill reactive on ArenaPlayerController. - PlayerCellPillEditor: horizontal control (+ / icon+value capsule / -) with self-managed enter/exit animation; edits reuse addCounters/castCommander. - Closes on tap-outside or, once interacted with, after the confirmation delay of inactivity; closing always returns to the basic cell view.
Tapping a numeric counter or cast icon on the advanced pages now performs its usual increment and then surfaces the focused +/- editor, so both the quick-info pill and the advanced page lead to the same editor. Boolean statuses keep their plain toggle.
Swap the +/- sides, widen each step button so its ripple runs behind the center capsule, add tap-and-hold escalation, and a background-less close button pinned to the cell corner.
Keep the pill editor code self-explanatory by removing verbose doc and inline comments that restate what the widgets already express.
JonathanEspinosaLong
force-pushed
the
info-pill-interactivity
branch
from
July 8, 2026 06:54
8989bef to
b789a30
Compare
JonathanEspinosaLong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks the info-pill interactivity work on top of
arena-quick-info-split.Adds commander-damage tap mode, the focused count-pill +/- editor, advanced-page entry points, hold-repeat editing, and related UI polish.
Commits
7 commits on top of
arena-quick-info-split(pill editor, hold-repeat, primaryContainerDim, etc.).