update traefik to v2.x #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joxit
reviewed
Sep 21, 2024
|
|
||
| #r set $registry_server "http://registry:5000"; | ||
| #r proxy_pass $registry_server; | ||
| proxy_pass http://registry:5000; |
There was a problem hiding this comment.
Why did you add the nginx configuration? It's not working with the bundled version?
There was a problem hiding this comment.
Only the following configuration is added to ensure that the default 60s is not interrupted when transferring large images.
client_body_timeout 300;
proxy_read_timeout 300;
proxy_send_timeout 300;
keepalive_timeout 150;
There was a problem hiding this comment.
Is this not necessary, or is it another issue?
There was a problem hiding this comment.
I think this is not necessary, I mean it adds more stuff to maintain if I'm updating the original nginx config for example and it makes the example more complex IMO
|
Hi, thank you for your contribution 😄 I posted one comment in your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated traefik example #380
This is the version I'm using on production