Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/example tableview #516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/example tableview #516

wants to merge 2 commits into from

Conversation

thisIsTheFoxe
Copy link

Summary

Hi,
Very cool project! ^-^

So, I was checking out #386 but wasn't able to reproduce it. However, I did find 2 other bugs that I fixed instead (didn't find directly related issues):

  • the hidden textField in the first cell isn't always hidden, especially when scrolling and re-loading cells
  • when updating the skeleton view (e.g. changing appearance, solid/gradient) the hidden (skeletonized) first textField would show for a fraction of a second

Requirements

@thisIsTheFoxe
Fix example table view textfield
9381113 
Sometimes disappears, sometimes first is visible.
@thisIsTheFoxe
Fix collection/table-view hidden views shown briefly
4c09c66 
When skeletonizing hidden views in a cell the transition causes them to briefly show for for just a fraction of a second.
Just ignoring the transition in this case resolves this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thisIsTheFoxe