Skip to content

Commit

Permalink
Replace constructor by explicit image_space (#87)
Browse files Browse the repository at this point in the history
  • Loading branch information
@blegat
blegat committed Aug 13, 2024
1 parent 5b67e14 commit 7281a35
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/null.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function MacaulayNullspace(matrix::AbstractMatrix{T}, basis) where {T}
return MacaulayNullspace(matrix, basis, Base.rtoldefault(T))
end

function MacaulayNullspace(
function image_space(
ν::MomentMatrix,
rank_check::RankCheck,
ldlt::LowRankLDLTAlgorithm = SVDLDLT(),
Expand Down Expand Up @@ -70,7 +70,7 @@ function compute_support!(
rank_check::RankCheck,
solver::ImageSpaceSolver,
)
null = MacaulayNullspace(ν, rank_check, solver.ldlt)
null = image_space(ν, rank_check, solver.ldlt)
ν.support = solve(null, solver.null)
return
end
Expand Down

2 comments on commit 7281a35

@blegat
Copy link
Member Author

@blegat blegat commented on 7281a35 Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/113041

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.8 -m "<description of version>" 7281a35851a2348403666a56207d3315b4fcb28f
git push origin v0.4.8

Please sign in to comment.