-
Notifications
You must be signed in to change notification settings - Fork 2
Enable stacking of 0-dim arguments #3 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I use
typeof(first(frame_axes))
rather thaneltype(prev)
for a "performance" reason.Mostly
Any[...]
vs [...]`, can you check if they still work similarly in terms of performance for non-trivial large arrays (ttfx time and average time)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do some comparisons today. Used
eltype(prev)
here because_apend_tuple
assumes a homogeneous tupleprev
anyways, and I thoughteltype
would be something likeeltype(::NTuple{N, T}) where {N, T}=T
. Upon closer inspection,eltype
on tuple (or rather tuple types) is a bit more complicated, but there does not seem to be obvious problems with type stability.With previous
typeof(first(frame_axes))
there were issues becauseframe_axes == ()
for 0-dim slices. Alternative: new helper_fill_range_type
with methods for non-empty tuples (falling back totypeof(first(frame_axes))
and for empty tuples (returningBase.Bottom
e.g. )