Reduce spurious allocations in setindex and getindex #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustafsson
force-pushed
the
BoundsError-skip-box
branch
from
d326ff8 to
38bbee9
Compare
Only store a Type{<:StaticArray} upon failed bounds checking of a
StaticArray to prevent boxing (i.e allocation).
A new @test_noalloc that captures variables to help the compiler avoid
additional spurious boxing/allocations.
gustafsson
force-pushed
the
BoundsError-skip-box
branch
from
38bbee9 to
201f7d2
Compare
|
I'm not particularly familiar with this part of the library but it looks like there is a failure on Julia 1.6. |
jishnub
reviewed
Apr 7, 2025
| @@ -188,7 +188,7 @@ julia> setindex(@SMatrix[2 4; 6 8], 1, 2) | |||
| return quote | |||
| @_propagate_inbounds_meta | |||
| @boundscheck if (index < 1 || index > $(L)) | |||
| throw(BoundsError(a, index)) | |||
| Base.throw_boundserror(a, index) | |||
There was a problem hiding this comment.
This is identical within a @noinline. Can we define the helper function in this package, instead of relying on Base internals?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only store a Type{<:StaticArray} upon failed bounds checking of a
StaticArray to prevent boxing (i.e allocation).
A new @test_noalloc that captures variables to help the compiler avoid
additional spurious boxing/allocations.