Skip to content

test: update github actions CI and run tests on LTS and pre #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,30 @@ jobs:
name: Julia ${{ matrix.group }} - ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
timeout-minutes: 50
permissions: # needed for julia-actions/cache to delete old caches
actions: write
contents: read
continue-on-error: ${{ matrix.version == 'pre' || matrix.version == 'nightly' }} # the CI badge will still pass if 'pre' or 'nightly' fails
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why I added this line. The failure on pre will be ignored in the final CI results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the icons below can be misleading since there is a big red X on pre. The CI badges will still be green howeve, as far as I know.

This is an issue with GitHub actions, the allow-failure setting does not exist for now actions/runner#2347

strategy:
fail-fast: false
matrix:
version: ['1']
version:
- 'lts' # long-term support release
- '1' # latest stable 1.x release
- 'pre' # latest stable prerelease
# - 'nightly' # commented since too noisy + 'pre' allows testing upcoming versions
os: [ubuntu-latest]
arch: [x64]
group:
- ControlSystems
- ControlSystemsBase
steps:
- uses: actions/checkout@v3
- uses: julia-actions/setup-julia@v1
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: julia-actions/cache@v1
- uses: julia-actions/cache@v2
env:
cache-name: cache-artifacts
with:
Expand All @@ -45,12 +53,11 @@ jobs:
- uses: julia-actions/julia-runtest@v1
env:
GROUP: ${{ matrix.group }}
# continue-on-error: ${{ matrix.version == 'nightly' }} # Allow nightly to fail and workflow still count as completed
- uses: julia-actions/julia-processcoverage@v1
with:
directories: src,lib/ControlSystemsBase/src,lib/ControlSystemsBase/ext
if: ${{ matrix.version == '1' }}
- uses: codecov/codecov-action@v4
- uses: codecov/codecov-action@v5
if: ${{ matrix.version == '1' }}
with:
file: lcov.info
Expand Down
Loading