Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CI workflows #363

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Modernize CI workflows #363

merged 4 commits into from
Mar 7, 2025

Conversation

omus
Copy link
Member

@omus omus commented Mar 5, 2025

Noticed CI failures in #362

@omus
Copy link
Member Author

omus commented Mar 5, 2025

error - 2025-03-05 21:01:59,213 -- Upload failed: {"message":"Token required because branch is protected"}

Some work to do for CodeCov

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (175e431) to head (f4aa9a7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   94.58%   92.85%   -1.74%     
==========================================
  Files           7        7              
  Lines         739      742       +3     
==========================================
- Hits          699      689      -10     
- Misses         40       53      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@omus
Copy link
Member Author

omus commented Mar 5, 2025

I have correctly guessed the CodeCov token secret name. Tokenless uploads are possible here but would need to be enabled. See: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

@omus
Copy link
Member Author

omus commented Mar 5, 2025

Make code coverage informational only

Coverage reductions no longer cause CI checks to fail

@omus omus requested a review from quinnj March 6, 2025 14:37
@omus omus mentioned this pull request Mar 6, 2025
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@quinnj quinnj merged commit 305aebc into main Mar 7, 2025
8 checks passed
@quinnj quinnj deleted the cv/ci-update branch March 7, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants