Skip to content

Incremental functionality (see commits) - #491

Merged
TimG1964 merged 18 commits into
JuliaData:masterfrom
TimG1964:Minor-Chart-revisions
Nov 8, 2026
Merged

TimG1964 merged 18 commits into
JuliaData:masterfrom
TimG1964:Minor-Chart-revisions

Conversation

@TimG1964

@TimG1964 TimG1964 commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

…images & comments guide

- Creating charts: add a Chart subtypes section mapping Excel's subtypes to
  kinds and addSeries keywords; complete the Limitations list
- Migration guide: add v0.11→v0.12 and v0.12→v0.13 sections and the
  behaviour changes in the v0.13 patch releases
- README and docs home: features list, quick start, fix ECMA-376 typo
- New guide page: Images, comments and sheet order

Co-Authored-By: Claude
- External links (web, mailto, file) via TargetMode="External" sheet
  relationships; internal links via `location`
- Empty cells take the display text and hyperlink font, as in Excel
- Links readable from read-only files, with or without the cell cache
- Fix copysheet! leaving the copy's hyperlinks pointing at relationship
  ids it didn't have
- Share relationship creation (add_part_rel!/add_external_rel!) and the
  single-cell reference check (comments/hyperlinks)
- Guide section, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
…ataValidation)

- Lists (from values or a range), whole/decimal numbers, dates, times,
  text length, custom formulas and message-only validations, with input
  and error messages; Excel's limits enforced, overlaps refused
- Read the Excel 2010 (x14) form too; readable from read-only files
- Fix renamesheet!/deletesheet!/copysheet! not updating references in
  x14 data validations (<xm:f> inside <x14:formula1>)
- Add _sheet_top_elements to read sheet elements without disturbing
  lazy loading; hyperlinks now use it
- Guide page, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- setColumnHidden/setRowHidden, isColumnHidden/isRowHidden
- groupRows/groupColumns (nested up to 7 levels, optionally collapsed),
  ungroupRows/ungroupColumns, getRowOutlineLevel/getColumnOutlineLevel;
  sheetFormatPr outlineLevelRow/Col kept up to date
- setColumnWidth shares the <cols> span-splitting helper, and adjacent
  definitions with the same settings are joined
- setRowHeight sets the height of empty rows instead of skipping them
- copysheet! copies row attributes (styles, hidden, outline levels)
- Guide page, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
…utoFilter)

- One filter per sheet; replacing it with the same range keeps its
  criteria
- A filter and an Excel Table may not overlap, checked both ways:
  setAutoFilter refuses a range on a table, and addtable!,
  writetable!(as_table=true), appendtable! and settotals! refuse to
  place or grow a table onto the filter
- Writes and removes the hidden _xlnm._FilterDatabase sheet name, which
  copysheet!, renamesheet! and deletesheet! keep in step
- Readable from read-only files, with or without the cache
- Filtering guide page, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- setSheetVisibility/getSheetVisibility (:visible, :hidden, :veryHidden);
  refuses to hide the last visible sheet, and moves the workbook's
  active tab off a sheet being hidden
- setTabColor/getTabColor/removeTabColor, on worksheets and chartsheets,
  with any colour form cell formats accept
- Worksheet.is_hidden is replaced by visibility; ws.is_hidden still
  reads and sets it
- Sheet settings guide page, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- protectSheet/unprotectSheet/isSheetProtected/getSheetProtection, with
  Excel's dialog options and an optional password (legacy hash, up to
  15 ASCII characters)
- setPageSetup/getPageSetup (orientation, paper size, scale or fit to
  pages), setPageMargins/getPageMargins, setPrintOptions/getPrintOptions
- setPrintArea/getPrintArea/removePrintArea and
  setPrintTitles/getPrintTitles/removePrintTitles, as the sheet-scoped
  _xlnm names Excel uses
- Shared helpers for sheet elements and <sheetPr> children; tab colour
  now uses them
- Guide sections, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- Unlock cells so they can be filled in on a protected sheet, and hide
  cells' formulas, as Excel's Format Cells > Protection tab does
- Empty cells are given the format without a value; other formatting
  is kept; each existing style is converted once per call
- Cell formats keep <alignment> before <protection>, as the schema
  requires: setAlignment appended its alignment after any protection
- Guide section, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
…uplication

- write.jl -> save.jl, setdata.jl, writetable.jl, sheetops.jl (XML tree
  helpers to xmlutil.jl); table.jl's Excel Tables half -> exceltables.jl
- copysheet! and deletesheet! broken into steps; one _map_book_views!
  replaces _shift_book_views!/_remap_book_views!
- Shared preamble for the cell format setters, simpler range bounds
  checks, shared <sheetData> search and row flush in first_cache_fill!,
  data bar colour defaults
- bench/maintainability.jl ignores docstrings, const table bodies,
  literal-only lines and include lines (duplicated lines 1,273 -> 134;
  functions over 100 lines 6 -> 3)
- No change in behaviour; read speed unchanged on bench/fixtures/large.xlsx

Co-Authored-By: Claude Opus 5.5
…lies

- readtable's four methods forward to one _readtable; eachtablerow's
  methods forward their keywords
- mergeCells/removeMergedCells and setColumnWidth/setRowHeight define
  their shared address methods once
- Duplicated lines (bench/maintainability.jl): 134 -> 0

Co-Authored-By: Claude Opus 5.5
- RowColEdit describes an insert or delete of rows or columns on a sheet
- _shift_formula, _shift_sqref, _shift_cellrange and _shift_cellref move
  references as Excel does: ranges grow and shrink, deleted references
  become #REF!, whole rows/columns move only on their own axis, and only
  references to the edited sheet move
- Strings, structured, external and 3-D references are left alone
- Not yet used: insertRows and the other edits follow (P2b)

Co-Authored-By: Claude Opus 5.5
- Cells, row heights and attributes move; references follow everywhere:
  formulas on every sheet, merged cells, conditional formats and data
  validations (ranges and formulas, x14 included), hyperlinks, the
  AutoFilter, frozen panes and selections, column widths, page breaks,
  defined names (print area and titles included) and chart series
- Ranges across an insert grow, ranges cut by a delete shrink, and
  references to deleted cells become #REF!
- Shared formulas stay shared when the edit moves all their cells alike;
  ones it would change unevenly are expanded to one formula per cell
- Deleting all the frozen rows and columns unfreezes the sheet
- Sheets with Excel Tables, images, charts or comments are refused
  until P2c/P2d
- Guide page, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- Drawing anchors move as each object's editAs says: twoCell objects
  stretch and shrink with their rows and columns, oneCell objects move
  keeping their size, absolute ones stay put; an object whose rows are
  all deleted shrinks to nothing; a corner on a row boundary counts as
  the end of the row before it
- Comments and their VML boxes move with their cells; a comment on a
  deleted cell is deleted; threaded comments move, but deleting their
  cell is refused before anything changes
- Sheets with images, charts or comments can now be edited; only sheets
  with Excel Tables are still refused (until P2d)
- Guide section, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- A table grows with rows/columns inserted inside it (new columns are
  named Column1, Column2, ... in its header), shrinks with ones deleted
  from it, moves with ones inserted at its start, and is deleted with
  all its rows or columns
- Its autoFilter follows its range (less any totals row); filter
  columns are renumbered; calculated column and totals formulas move
- References to a deleted table or column become #REF! in formulas,
  names, conditional formats, validations, charts and tables
- Deleting a table's header row, totals row or all its data rows on
  their own is refused before anything changes
- Sheets with tables can now be edited; addtable! is broken into steps
- Guide section, docstrings, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- deleteImage deletes the images at a cell, or one from getImages; the
  picture file goes unless another image still shows it, and an empty
  drawing is removed; getImages is now declared public
- Charts.deleteChart deletes a chart on a worksheet with the parts only
  it uses (and a chartEx chart's _xlchart names); chartsheets refused
- getThreadedComments/getThreadedComment read Excel 365 threads: author,
  text, date, resolved, and replies; still not written
- Guide sections, API docs, CHANGELOG

Co-Authored-By: Claude Opus 5.5
- Integers and cell references are written straight into buffers
  rather than through strings; floats use print; tags and column
  letters are built once per sheet
- Each thread writes a chunk of rows into one buffer, and the sheet goes
  into the file in pieces rather than being joined and copied
- Output is byte-for-byte unchanged
- bench/worksheet_write.jl times each write path on its own, without
  fixtures: writetable of 100,000 x 8 strings 772 -> 336 MiB, numbers
  986 -> 666 MiB; open "rw" and save 1087 -> 767 MiB

Co-Authored-By: Claude Opus 5.5
The xl_* `readtable` and `writetable` benchmarks read only the title on
row 1, returning no data rows, so they measured little more than `open`.
Pass `first_row=5`, and on xl_gaps also `stop_in_empty_row=false,
keep_empty_rows=true`.

Drop `readtable_subset` on xl_gaps, where it read only 15 rows. Stop the
run if a fixture's table has fewer than 100 rows. Note in the README that
earlier xl_* results aren't comparable.
Folder entries such as "xl/" (written by openpyxl and some zip tools) were
kept as binary parts, and saving in "rw" mode then failed in ZipArchives.
Skip them in stream_files, and test an rw round trip of openpyxl.xlsx.

The "custom numFmt ids" test now also renumbers the cellXfs that use the
format, so its SAVE_FILES output no longer has a dangling numFmtId.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.26840% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.45%. Comparing base (86286c3) to head (4bb0a85).

Files with missing lines Patch % Lines
src/save.jl 96.82% 14 Missing ⚠️
src/setdata.jl 95.53% 12 Missing ⚠️
src/datavalidation.jl 94.65% 10 Missing ⚠️
src/sheetsettings.jl 96.88% 9 Missing ⚠️
src/cellformats/rowscols.jl 97.69% 6 Missing ⚠️
src/shifttables.jl 96.83% 5 Missing ⚠️
src/rowcoledit.jl 99.08% 3 Missing ⚠️
src/hyperlinks.jl 98.54% 2 Missing ⚠️
src/autofilter.jl 97.56% 1 Missing ⚠️
src/cellformats/protection.jl 98.14% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   97.35%   97.45%   +0.09%     
==========================================
  Files          49       64      +15     
  Lines       12490    14078    +1588     
==========================================
+ Hits        12160    13720    +1560     
- Misses        330      358      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimG1964
TimG1964 merged commit 64ed13f into JuliaData:master Nov 8, 2026
16 checks passed
@TimG1964
TimG1964 deleted the Minor-Chart-revisions branch November 8, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants