Skip to content

Change device! function parameter type from Int32 to Int #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2025
Merged

Change device! function parameter type from Int32 to Int #2906

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df20d95
Change device! function parameter type from Int32 to Int
simone-silvestri Oct 1, 2025
7c201f4
Apply suggestion
vchuravy Oct 1, 2025
b047c6b
Apply suggestion from
vchuravy Oct 1, 2025
238aabe
Apply suggestion from @vchuravy
vchuravy Oct 1, 2025
b34777c
Apply suggestion
vchuravy Oct 1, 2025
b624e70
fix tests
simone-silvestri Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/CUDAKernels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,17 @@ end
## device operations

function KA.ndevices(::CUDABackend)
return ndevices()
return Int(ndevices())
end

function KA.device(::CUDABackend)
function KA.device(::CUDABackend)::Int
deviceid(CUDA.active_state().device) + 1
end

function KA.device!(::CUDABackend, id::Int32)
function KA.device!(backend::CUDABackend, id::Int)
if !(0 < id <= KA.ndevices(backend))
throw(ArgumentError("Device id $id out of bounds."))
end
device!(id - 1)
end

Expand Down