Backports for 5.8.5 #2916
Merged
Backports for 5.8.5 #2916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't perform a dense copy, which we started dispatching to after the Adapt.jl Union now lists Hermitian as well (Symmetric had been broken before).
maleadt
force-pushed
the
backportmapred
branch
from
9c3a9bf to
84b3f75
Compare
maleadt
changed the title
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/cusolver/linalg.jl b/lib/cusolver/linalg.jl
index 2776916f2..ace05099a 100644
--- a/lib/cusolver/linalg.jl
+++ b/lib/cusolver/linalg.jl
@@ -112,9 +112,9 @@ end
# make copyto! for Hermitian and Symmetric dispatch to the Base implementation
# instead of being overridden by GPUArrays' dense copy (because of AnyGPUArray)
-Base.copyto!(dst::Symmetric{<:Any,<:CuMatrix}, src::Symmetric{<:Any,<:CuMatrix}) =
+Base.copyto!(dst::Symmetric{<:Any, <:CuMatrix}, src::Symmetric{<:Any, <:CuMatrix}) =
@invoke copyto!(dst::Symmetric, src::Symmetric)
-Base.copyto!(dst::Hermitian{<:Any,<:CuMatrix}, src::Hermitian{<:Any,<:CuMatrix}) =
+Base.copyto!(dst::Hermitian{<:Any, <:CuMatrix}, src::Hermitian{<:Any, <:CuMatrix}) =
@invoke copyto!(dst::Hermitian, src::Hermitian)
# eigenvalues |
|
I added #2913 to make CI work. |
`cutensornetCreateNetworkDescriptor` expects Int64 as strides.
[only julia]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #2907 to 5.8 branch. Also bumps the patch version