Skip to content

Remove diagm in favour of GPUArrays #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2025
Merged

Remove diagm in favour of GPUArrays #2979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db43cf7
Remove diagm in favour of GPUArrays
kshyatt Nov 19, 2025
73589b2
Remove sources from Project.toml
kshyatt Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions lib/cublas/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,40 +581,6 @@ function LinearAlgebra.rmul!(A::Adjoint{Tt, <:CuMatrix{Tt}}, B::Diagonal{Td,<:Cu
return adjoint(At)
end

# diagm

LinearAlgebra.diagm(kv::Pair{<:Integer,<:CuVector}...) = _cuda_diagm(nothing, kv...)
LinearAlgebra.diagm(m::Integer, n::Integer, kv::Pair{<:Integer,<:CuVector}...) = _cuda_diagm((Int(m),Int(n)), kv...)
LinearAlgebra.diagm(v::CuVector) = LinearAlgebra.diagm(0 => v)
LinearAlgebra.diagm(m::Integer, n::Integer, v::CuVector) = LinearAlgebra.diagm(m, n, 0 => v)

function _cuda_diagm(size, kv::Pair{<:Integer,<:CuVector}...)
A = LinearAlgebra.diagm_container(size, kv...)
for p in kv
inds = LinearAlgebra.diagind(A, p.first)
copyto!(view(A, inds), p.second)
end
return A
end

function LinearAlgebra.diagm_container(size, kv::Pair{<:Integer,<:CuVector}...)
T = promote_type(map(x -> eltype(x.second), kv)...)
U = promote_type(T, typeof(zero(T)))
return CUDA.zeros(U, LinearAlgebra.diagm_size(size, kv...)...)
end

function LinearAlgebra.diagm_size(size::Nothing, kv::Pair{<:Integer,<:CuVector}...)
mnmax = mapreduce(x -> length(x.second) + abs(Int(x.first)), max, kv; init=0)
return mnmax, mnmax
end
function LinearAlgebra.diagm_size(size::Tuple{Int,Int}, kv::Pair{<:Integer,<:CuVector}...)
mmax = mapreduce(x -> length(x.second) - min(0,Int(x.first)), max, kv; init=0)
nmax = mapreduce(x -> length(x.second) + max(0,Int(x.first)), max, kv; init=0)
m, n = size
(m ≥ mmax && n ≥ nmax) || throw(DimensionMismatch(lazy"invalid size=$size"))
return m, n
end

# symmetric mul!

op_wrappers = ((identity, T -> 'N', identity),
Expand Down