Remove JET from Project.toml, get tests passing, bump to Julia 1.10#96
Merged
Remove JET from Project.toml, get tests passing, bump to Julia 1.10#96
Conversation
Added (presumably accidentally) in a0b7026
Member
Author
|
Test failure on Julia 1.0 explained here: a0b7026#commitcomment-151044599 |
timholy
changed the title
Member
Author
|
Hmm, Documenter 1 is also not compatible with Julia 1.0. I think the best call at this point is to bump to Julia 1.10 (LTS). There was also a broken doctest due to differences in CPU rounding, and the fix was non-obvious. xref JuliaDocs/Documenter.jl#2277 (comment) |
Member
Author
|
All pass. I'll wait a bit before merging in case anyone has objections to jumping to Julia 1.10. |
timholy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added (presumably accidentally) in a0b7026
CC @sjkelly