Create searching.jl #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the findTraingle() and prevedge() method
sjkelly
reviewed
Feb 4, 2023
| @@ -0,0 +1,41 @@ | |||
| using GeometryBasics | |||
There was a problem hiding this comment.
Suggested change
| using GeometryBasics |
sjkelly
reviewed
Feb 4, 2023
| @@ -0,0 +1,41 @@ | |||
| using GeometryBasics | |||
| using Delaunator | |||
There was a problem hiding this comment.
Suggested change
| using Delaunator |
dgleich
reviewed
Feb 6, 2023
| n = 0 | ||
|
|
||
| while true | ||
| next = Delaunator._nextedge(current) |
There was a problem hiding this comment.
You should be able to drop the Delaunator. prefix since it's all in the same module.
|
|
||
| while true | ||
| next = Delaunator._nextedge(current) | ||
| pc = t.points[(t._triangles[current])] |
There was a problem hiding this comment.
for various reasons, it's better to assign points = t.points outside the for loop. (or it was at some point.) Same with t._triangles. and t._halfedges...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the findtraingle() and prevedge() method