Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to franklin #18

Merged
merged 10 commits into from
Oct 29, 2021
Merged

migrating to franklin #18

merged 10 commits into from
Oct 29, 2021

Conversation

tlienart
Copy link
Contributor

@tlienart tlienart commented Oct 29, 2021

closes #17

Note: I didn't try to solve #11 , just migrated the content as it is now.

preview: https://tlienart.github.io/juliagraphs.github.io/

Note: there's a difference in the font; not sure why that is; probably not very important.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 29, 2021

Is it necessary to commit all these files into the source? I mean the fonts and such.

Just asking in case they are auto-generated and/or accidentally checked in.

@tlienart
Copy link
Contributor Author

if you never intend to use KaTeX we can remove that which is most of the files.

@ViralBShah
Copy link
Contributor

I suppose it can be added back if necessary - but seems like a pretty plain site to me otherwise.

@ViralBShah
Copy link
Contributor

Would it be easy to simplify the page design a bit to remove the two column layout? Or is that a lot of CSS work and not worth doing?

@tlienart
Copy link
Contributor Author

alright I trimmed to the essentials :)

@ViralBShah
Copy link
Contributor

Thanks! Is it possible to preview? Or I can just go for the merge and fix it as we go along...

@tlienart
Copy link
Contributor Author

tlienart commented Oct 29, 2021

for the preview, yes, though the prepath will need to be removed before the merge.

(will post here when the preview is generated)

@tlienart
Copy link
Contributor Author

Preview: https://tlienart.github.io/juliagraphs.github.io/

(before merging, remove the line prepath=... in the config.md)

@ViralBShah
Copy link
Contributor

This seems to visually look the same as what we had before, right? Is it just a simplification of the underlying code?

@ViralBShah ViralBShah mentioned this pull request Oct 29, 2021
7 tasks
@tlienart
Copy link
Contributor Author

it's identical to what was there before, the only visible change is that the font is not identical (I'm not sure why).

If you compare the HTML of https://tlienart.github.io/juliagraphs.github.io/ and https://juliagraphs.org you'll see that it's basically identical

@ViralBShah
Copy link
Contributor

Ok - can you delete the prepath? I'll have to make a PR to your PR otherwise. Let's merge.

@tlienart
Copy link
Contributor Author

yep done

@ViralBShah ViralBShah merged commit 1134083 into JuliaGraphs:master Oct 29, 2021
@tlienart
Copy link
Contributor Author

nice: https://juliagraphs.org 👍

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 29, 2021

So after this PR, in the github pages settings, I am unable to set the CNAME to juliagraphs.org. It claims the name is taken, and as a result none of the other docs links on the packages are working.

I manually pushed a CNAME file to this repo, but that doesn't seem to help. For example, the Graphs.jl docs link doesn't work now. I am a bit confused that juliagraphs.org actually works.

It says "The custom domain juliagraphs.org is already taken", but I wonder which repo is claiming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Franklin
2 participants