-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating to franklin #18
Conversation
Is it necessary to commit all these files into the source? I mean the fonts and such. Just asking in case they are auto-generated and/or accidentally checked in. |
if you never intend to use KaTeX we can remove that which is most of the files. |
I suppose it can be added back if necessary - but seems like a pretty plain site to me otherwise. |
Would it be easy to simplify the page design a bit to remove the two column layout? Or is that a lot of CSS work and not worth doing? |
alright I trimmed to the essentials :) |
Thanks! Is it possible to preview? Or I can just go for the merge and fix it as we go along... |
for the preview, yes, though the (will post here when the preview is generated) |
Preview: https://tlienart.github.io/juliagraphs.github.io/ (before merging, remove the line |
This seems to visually look the same as what we had before, right? Is it just a simplification of the underlying code? |
it's identical to what was there before, the only visible change is that the font is not identical (I'm not sure why). If you compare the HTML of https://tlienart.github.io/juliagraphs.github.io/ and https://juliagraphs.org you'll see that it's basically identical |
Ok - can you delete the prepath? I'll have to make a PR to your PR otherwise. Let's merge. |
yep done |
nice: https://juliagraphs.org 👍 |
So after this PR, in the github pages settings, I am unable to set the CNAME to juliagraphs.org. It claims the name is taken, and as a result none of the other docs links on the packages are working. I manually pushed a CNAME file to this repo, but that doesn't seem to help. For example, the Graphs.jl docs link doesn't work now. I am a bit confused that juliagraphs.org actually works. It says "The custom domain |
closes #17
Note: I didn't try to solve #11 , just migrated the content as it is now.
preview: https://tlienart.github.io/juliagraphs.github.io/
Note: there's a difference in the font; not sure why that is; probably not very important.