Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Base.convert methods between AbstractString and Kind #500

Merged
merged 3 commits into from
Oct 6, 2024

Commits on Sep 3, 2024

  1. Remove the method convert(::Type{String}, ::Kind)

    This patch removes the method `convert(::Type{String}, ::Kind)` used for
    converting kinds to strings and replaces it with the already existing
    method of `Base.string`. There are two reason for this: i) the method
    causes invalidations when loading the package and ii) `convert` is
    called implicitly in e.g. constructors and should therefore typically
    only be defined between similar enough types.
    fredrikekre committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    15abadd View commit details
    Browse the repository at this point in the history
  2. Remove the method Base.convert(::Type{Kind}, ::String)

    This patch removes the method `Base.convert(::Type{Kind}, ::AbstractString)`
    and replaces it with a `Kind(::AbstractString)` constructor. The reason
    for this is that `convert` is called implicitly in e.g. constructors and
    should therefore typically only be defined between similar enough types.
    fredrikekre committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    58b31ef View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    ace7f89 View commit details
    Browse the repository at this point in the history